Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 50 improve logging #333

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Feature 50 improve logging #333

merged 8 commits into from
Sep 16, 2024

Conversation

John-Sharples
Copy link

@John-Sharples John-Sharples commented Sep 13, 2024

  • introduces new cli option --loglevel which can be used to set the verbosity of the logging. If set this will overwrite the verbose setting in the XML load file.
  • Removes all instances of logging and replaces them with the common logger in METreformat.util
  • All classes/functions now require a logger argument, or create an instance of the common logger
  • Adopts a log message format like
    20240916 17:57:58||root||met_db_load.py: main|| [INFO]: User name is: root

Pull Request Testing

  • Describe testing already performed for these changes:

    Ran pytest and tested from cli with sample data

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Test with more datasets

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes or No]
    Yes, tests updated to handle new functionality

  • [x Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    minor changes

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@bikegeek bikegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loaded some data on mohawk, log has all relevant information

@bikegeek bikegeek merged commit d714793 into develop Sep 16, 2024
15 checks passed
@bikegeek bikegeek deleted the feature_50_improve_logging branch September 16, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

2 participants