Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix schema file missing on install #341

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

georgemccabe
Copy link
Contributor

Change Summary

  • Replaces deprecated setup.py with pyproject.toml configurations to pip install METdataio packages (METdbLoad, METreformat, and METreadnc).
  • Added schema file to package data so it is available upon install
  • Fix pip-audit GitHub Actions issues by reverting back to ubuntu 22.04 because ubuntu-latest now points to 24.04 and there are issues with the install on this OS

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Run any additional testing needed to ensure that nothing is broken

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METdataio-3.0.0 milestone Oct 14, 2024
@georgemccabe georgemccabe requested a review from bikegeek October 14, 2024 22:54
@bikegeek bikegeek merged commit f2e7f89 into develop Oct 15, 2024
13 checks passed
@bikegeek bikegeek deleted the bugfix_schema_missing_on_install branch October 15, 2024 22:27
@jprestop jprestop added the component: release engineering Release engineering issue label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: release engineering Release engineering issue
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

3 participants