-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 361 install instruct #363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e tests when changes are pushed to main_vX.Y and develop branches
…000V.stat no longer relevant due to additional columns introduced in one of the beta releases
#358) * Updates to version numbers, dates, rotation of authorship for coordinated release. * Consolidated the update section * Added None under New Functionality --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
…feature_361_install_instruct
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
jprestop
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few suggested changes for you to review @bikegeek.
23 tasks
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
increased number of ^ to longer header
jprestop
reviewed
Jan 28, 2025
jprestop
reviewed
Jan 28, 2025
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
jprestop
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @bikegeek and @lisagoodrich. I approve this request.
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
History: I had A LOT of trouble getting a branch. (I still don't have a working METdataio sub branch on my local machine.) I was able to get a branch going on the github web BUT I wasn't careful after all of my problems and I branched off of MAIN not develop.
I copied the text into readthedocs. I made formatting (bolding, italics, periods, code blocks, etc) changes.
When talking to Minna, she discussed compairing it to the other modules. I looked at METplotpy and it looks pretty similar, but not identical. Please let me know if changes are needed.
Here is the working branch: https://metdataio.readthedocs.io/en/feature_361_install_instruct/Users_Guide/installation.html
Julie:
Minna:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [1/31/25] date is negoicable.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases