Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 361 install instruct #363

Merged
merged 28 commits into from
Jan 28, 2025
Merged

Feature 361 install instruct #363

merged 28 commits into from
Jan 28, 2025

Conversation

bikegeek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    History: I had A LOT of trouble getting a branch. (I still don't have a working METdataio sub branch on my local machine.) I was able to get a branch going on the github web BUT I wasn't careful after all of my problems and I branched off of MAIN not develop.

I copied the text into readthedocs. I made formatting (bolding, italics, periods, code blocks, etc) changes.

When talking to Minna, she discussed compairing it to the other modules. I looked at METplotpy and it looks pretty similar, but not identical. Please let me know if changes are needed.

  1. Please review the grammar and formatting.
  2. I think you have standardized formatting for the sentence, "Please change ‘your-conda-env-name’ to the correct location." but I couldn't find it after a 5 minute search through the other documentation. Please review this.
  3. I'm not sure if I should have quotes or ticks or nothing around the "-e" and the period in the forth and fifth bullet.

Minna:

  1. I copied the text into section 3.3.1.1 and 3.3.1.2, confirm this is where you want the new information.
  2. Double check the {} in the codes to make sure they are what you want. I didn't test any of this.
  3. Are there any other changes you see?
  4. Please double check the projects and milestones. I was guessing.
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [1/31/25] date is negoicable.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

bikegeek and others added 13 commits November 14, 2024 13:23
…e tests when changes are pushed to main_vX.Y and develop branches
…000V.stat

no longer relevant due to additional columns introduced in one of the beta releases
#358)

* Updates to version numbers, dates, rotation of authorship for coordinated release.

* Consolidated the update section

* Added None under New Functionality

---------

Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
@bikegeek bikegeek mentioned this pull request Jan 28, 2025
15 tasks
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggested changes for you to review @bikegeek.

@jprestop jprestop linked an issue Jan 28, 2025 that may be closed by this pull request
23 tasks
bikegeek and others added 12 commits January 28, 2025 12:17
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
increased number of ^ to longer header
bikegeek and others added 2 commits January 28, 2025 12:41
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @bikegeek and @lisagoodrich. I approve this request.

@bikegeek bikegeek merged commit 150aa81 into develop Jan 28, 2025
8 of 9 checks passed
@bikegeek bikegeek deleted the feature_361_install_instruct branch January 28, 2025 19:45
@bikegeek bikegeek restored the feature_361_install_instruct branch January 28, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Additional instructions for installing METdataio
4 participants