Address Warnings from pandas in METplotpy ROC diagram code

[bikegeek]

Describe the Problem

Related to METcalcpy issue 249:
dtcenter/METcalcpy#249

This is observed with pandas 1.5 but not with 1.2.3

Expected Behavior

When generating a ROC diagram with PCT data, the FutureWarning is generated from the roc_diagram_series.py code in the _create_series_points() method:

    elif self.config.linetype_pct:
        roc_df = pstats._calc_pct_roc(subset_df)
        pody = roc_df['pody']
        pody = pd.Series([1]).append(pody, ignore_index=True)
        pody = pody.append(pd.Series([0]), ignore_index=True)
        pofd = roc_df['pofd']
        pofd = pd.Series([1]).append(pofd, ignore_index=True)
        pofd = pofd.append(pd.Series([0]), ignore_index=True)
        thresh = roc_df['thresh']
        thresh = pd.Series(['']).append(thresh, ignore_index=True)
        thresh = thresh.append(pd.Series(['']), ignore_index=True)
       
        return pofd, pody, thresh

Remedy:

Replace pody.append with pd.concat([pody, pd.Series([0])]) in above code block and in the code for the CTC line type.

Environment

Describe your runtime environment:
*1. Machine: mac laptop 'blenny'
*2. OS: MacOS
3. Software version number(s) v2.0

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2792542, 2773542

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Organization level Project for support of the current coordinated release
• Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
• Fix the bug and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Development issues
  Select: Organization level software support Project for the current coordinated release
  Select: Milestone as the next bugfix version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Development issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Close this issue.