-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 383 tcmpr doc test #441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feature_383_tcmpr_doc_test
…g one config file and logging to replace printing to stdout
… file, logging support added to replace print statements
…onfig file and logging to replace print statements
… file and logging to replace print statements
…onfig file and logging replaces printing to stdout
…ned in a single config file
…onfig file and added logging
…ot types defined in a single config file. Also added logging
…ned in a single config file and added logging
…_WIND)_relperf.png not relevant
…_WIND)_boxplot.png not relevant
…feature_383_tcmpr_doc_test
set hfip_bsln.lower() to a variable
hankenstein2
approved these changes
May 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran the tests on seneca, all plots appeared as expected and test passed
23 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
on host 'seneca':
/d1/projects/TCMPR_TCDIAG
generated multiple plot types within one config file and single plot type within one config file
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
https://metplotpy.readthedocs.io/en/feature_383_tcmpr_doc_test/Users_Guide/tcmpr_plots.html
Work in /d1/projects/TCMPR_TCDIAG and run the setup_env.bash script to set up the environments
Instructions based on working/testing on 'seneca'
clone the feature_383_tcmpr_doc_test branch of METplotpy
clone the develop branch of METcalcpy
if working on 'seneca', use this environment:
/d1/personal/mwin/miniconda3/envs/mp_analysis_env
Run the tests in $METPLOTPY/test/tcmpr_plots/
pytest test_tcmpr_plots.py
Using the config file under $METPLOTPY/test/tcmpr_plots/tcmpr_multi_plots.yaml
set these to appropriate locations:
The baseline_file and column_info_file files are in the $METPLOTPY/metplotpy/plot/tcmpr_plots directory
boxplot
mean skill
median skill
relative performance
mean
median
rank
python $METPLOTPY_BASE/metplotpy/plots/tcmpr_plots/tcmpr.py /path/to/tcmpr_multi_plots.yaml
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes ]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[?] Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [At earliest convenience].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes