Feature 342 tcdiag tcmpr plotter

[bikegeek]

Pull Request Testing

• Describe testing already performed for these changes:
  
  can successfully generate a time-series plot for all lead times, for a single initialization time, for a single storm (Ian) that is consistent with the data. The CIRA scientist has verified the correctness of the plot:
  

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

Generate the plot:

• on 'seneca', use the /d1/personal/mwin/miniconda3/envs/mp_analysis_env conda environment

• clone the develop version of METdataio

• clone the feature_342_tcdiag_tcmpr_plotter version of METplotpy

• set up PYTHONPATH:
  - PYTHONPATH=$CALCPY:$CALCPY/metcalcpy:$PLOTPY:$PLOTPY/metplotpy:$PLOTPY/metplotpy/plots

• Use reformatted data (remove the .txt suffix):

  tc_pairs_reformatted_tc_diag.tcst.txt

• Use this yaml config file (remove .txt suffix), and change paths to output, log, and input data:
  tcmpr_timeseries_plot.yaml.txt

• Generate the plot:

  • python $PLOTPY/metplotpy/plots/tcmpr_plots/tcmpr.py /path/to/tcmpr_timeseries_plot.yaml

Plot should look like this:

NOTE
I have this already set up on 'seneca':

/d1/personal/mwin/feature_342_tcmpr_plots_for_tcdiag/METplotpy/metplotpy/plots/tcmpr_plots

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

• Do these changes include sufficient testing updates? [NA]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Do these changes introduce new SonarQube findings? [Unsure]
  
  If yes, please describe:

• Please complete this pull request review by [Earliest convenience, a use case needs this code].
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[hankenstein2]

Ran on seneca, tests completed and the plots matched.

[hankenstein2]

Fixed a sonar qube complaint