Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grid-Stat configuration options for distance_map dictionary #1089

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Aug 18, 2021 · 0 comments · Fixed by #1190
Closed
8 of 20 tasks

Add Grid-Stat configuration options for distance_map dictionary #1089

JohnHalleyGotway opened this issue Aug 18, 2021 · 0 comments · Fixed by #1190
Assignees
Labels
priority: medium Medium Priority requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Aug 18, 2021

Describe the Enhancement

The issue dtcenter/MET#1673 and corresponding pull request dtcenter/MET#1857 add new columns to the distance map (DMAP) line type created by the Grid-Stat tool.

This includes one change to the Grid-Stat configuration file in the "distance_map" dictionary:

distance_map = {
   baddeley_p        = 2;
   baddeley_max_dist = NA;
   fom_alpha         = 0.1;
   zhu_weight        = 0.5;
   beta_value(n)     = n * n / 2.0;
}

The beta_value(n) function is a new configuration option. The wrapped Grid-Stat config file in METplus should be updated to handle it.

Please see existing documentation for more details about the configuration options, science, and equations.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues needed.

Relevant Deadlines

Prior to the METplus 4.1.0 release.

Funding Source

2702691

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: George
  • Select scientist(s) or no scientist required: no scientist needed

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: use case configuration priority: high High Priority requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Aug 18, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-4.1.0 milestone Aug 18, 2021
@georgemccabe georgemccabe changed the title Add Grid-Stat configuration options related to GBETA. Add Grid-Stat configuration options for distance_map dictionary Aug 31, 2021
@georgemccabe georgemccabe added priority: medium Medium Priority and removed priority: high High Priority labels Aug 31, 2021
georgemccabe added a commit that referenced this issue Oct 4, 2021
@georgemccabe georgemccabe linked a pull request Oct 4, 2021 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants