Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wrapped MET config files to reference MET_TMP_DIR in tmp value #1101

Closed
7 of 21 tasks
georgemccabe opened this issue Aug 23, 2021 · 0 comments · Fixed by #1262
Closed
7 of 21 tasks

Update wrapped MET config files to reference MET_TMP_DIR in tmp value #1101

georgemccabe opened this issue Aug 23, 2021 · 0 comments · Fixed by #1262
Assignees
Labels
METplus: Configuration priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

The default value is currently /tmp, however some machines discourage using this directory to write temp files. When running through METplus wrappers, the environment variable MET_TMP_DIR is set which overrides this value. Running with the wrapped MET config files outside of the wrappers (via command line) require the other environment variables to be set to run or it will fail. If all of the env vars set for a command are set, then it will include MET_TMP_DIR, however this may not always be the case. Setting the value for tmp to $(MET_TMP_DIR) will ensure that the value is overridden properly when running by hand and make it clear to users that the value set for tmp in those files is not being used.

Describe the Enhancement

Change the files in parm/met_config to reference the MET_TMP_DIR environment variable instead of /tmp.

Time Estimate

~< 1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

4.1.0

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: use case configuration priority: medium Medium Priority requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplus: Configuration labels Aug 23, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Aug 23, 2021
georgemccabe added a commit that referenced this issue Nov 11, 2021
… MET config files to prevent writing tmp files to /tmp when running MET commands outside of METplus wrappers. This forces the user to set the MET_TMP_DIR environment variable in their environment when running MET commands using a wrapped MET config file
@georgemccabe georgemccabe self-assigned this Nov 11, 2021
@georgemccabe georgemccabe mentioned this issue Nov 12, 2021
12 tasks
@georgemccabe georgemccabe linked a pull request Nov 12, 2021 that will close this issue
12 tasks
@TaraJensen TaraJensen added reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
METplus: Configuration priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants