Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new climo_cdf.direct_prob flag #1392

Closed
8 of 20 tasks
JohnHalleyGotway opened this issue Feb 1, 2022 · 0 comments · Fixed by #1396
Closed
8 of 20 tasks

Add support for new climo_cdf.direct_prob flag #1392

JohnHalleyGotway opened this issue Feb 1, 2022 · 0 comments · Fixed by #1396
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplus: Configuration priority: medium Medium Priority requestor: NOAA/CPC NOAA Climate Prediction Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Feb 1, 2022

Describe the Enhancement

MET PR dtcenter/MET#2034 for issue dtcenter/MET#2003 adds a new option to the climo_cdf dictionary. This task is to make this option configurable via METplus.

Also support climo_cdf in the Series-Analysis config file. It appears in the following MET config files (Series-Analysis is the only new one):

EnsembleStatConfig_default:climo_cdf = {
GridStatConfig_default:climo_cdf = {
PointStatConfig_default:climo_cdf = {
SeriesAnalysisConfig_default:climo_cdf = {

Please see feature_2003_briercl documentation for details or develop, after the PR has been merged.

Also assigning to @j-opatz since he's applying this new functionality to NOAA/CPC data and is best suited to advise on the utility of this option.

Time Estimate

2 hours (?)

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues required.

Relevant Deadlines

Include in METplus 4.1 coordinated release.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @georgemccabe
  • Select scientist(s) or no scientist required: @j-opatz

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: NOAA/CPC NOAA Climate Prediction Center METplus: Configuration labels Feb 1, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the METplus-4.1.0 milestone Feb 1, 2022
georgemccabe added a commit that referenced this issue Feb 1, 2022
…mandBuilder so it can be used by SeriesAnalysis, made write_bins optional (set by default but can be not set for SeriesAnalysis), added direct_prob boolean
georgemccabe added a commit that referenced this issue Feb 1, 2022
…idStat, and PointStat, add support for climo_cdf.cdf_bins/center_bins/direct_prob for SeriesAnalysis
@georgemccabe georgemccabe linked a pull request Feb 3, 2022 that will close this issue
12 tasks
@georgemccabe georgemccabe changed the title Add support for new climo_cdf.direct_prob flag. Add support for new climo_cdf.direct_prob flag Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplus: Configuration priority: medium Medium Priority requestor: NOAA/CPC NOAA Climate Prediction Center type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants