Bugfix: Phase Diagram use case writes all output into OUTPUT_BASE instead of INPUT_BASE

[georgemccabe]

This came up in discussion #1703

Describe the Problem

The model_applications/s2s_mjo/UserScript_obsERA_obsOnly_PhaseDiagram use case (previously in s2s) fails because the use case tries to write output data to a directory under {INPUT_BASE}. In most cases the input data is owned by another user so they cannot write output to that area. All use cases should always write any output and intermediate files relative to {OUTPUT_BASE} to prevent any issues like this.

Expected Behavior

The use case should run without error when the INPUT_BASE is owned by another user and the user running the use case does not have permission to write into INPUT_BASE. All files created by the use case should be written under OUTPUT_BASE.

Environment

Describe your runtime environment:
*1. Machine: seneca
*2. OS: Debian Buster
*3. METplus 4.1.0 and develop

To Reproduce

Describe the steps to reproduce the behavior:
1. Set INPUT_BASE to /d1/projects/METplus/METplus_Data
2. Run UserScript_obsERA_obsOnly_PhaseDiagram use case

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2792541

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Organization level Project for support of the current coordinated release
• Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
• Fix the bug and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Add any new Python packages to the METplus Components Python Requirements table.
• Push local changes to GitHub.
• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Linked issues
  Select: Organization level software support Project for the current coordinated release
  Select: Milestone as the next bugfix version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Linked issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Close this issue.