Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatAnalysis - Allow filename template tags in jobs #1862

Closed
9 of 22 tasks
georgemccabe opened this issue Oct 11, 2022 · 0 comments · Fixed by #1869
Closed
9 of 22 tasks

StatAnalysis - Allow filename template tags in jobs #1862

georgemccabe opened this issue Oct 11, 2022 · 0 comments · Fixed by #1869
Assignees
@georgemccabe
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: python wrapper METplus: Configuration priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Milestone
METplus-5.0.0

Comments

@georgemccabe
Copy link
Collaborator

Currently filename template tags are only substituted in job args when using [dump_row_file] or [out_stat_file] and STAT_ANALYSIS_DUMP_ROW_TEMPLATE or STAT_ANALYSIS_OUT_STAT_TEMPLATE.

Describe the Enhancement

Add support to allow filename template tags with STAT_ANALYSIS_JOB* variables.

Time Estimate

~1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

5.0.0

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required - @CPKalb as needed for testing

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing component: python wrapper priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project METplus: Configuration labels Oct 11, 2022
@georgemccabe georgemccabe added this to the METplus-5.0.0 milestone Oct 11, 2022
@georgemccabe georgemccabe self-assigned this Oct 11, 2022
georgemccabe added a commit that referenced this issue Oct 11, 2022
@georgemccabe
per #1862, add support for using filename template tags anywhere in t…
5c1de4a 
…he JOB args
@georgemccabe georgemccabe mentioned this issue Oct 17, 2022
Merged
14 tasks
@georgemccabe georgemccabe moved this from In Progress to Review in METplus-Wrappers-5.0.0-beta4 (10/26/22) Oct 17, 2022
@georgemccabe georgemccabe linked a pull request Oct 18, 2022 that will close this issue
Feature 1842 StatAnalysis - multiple issues #1869
Merged
14 tasks
Repository owner moved this from Review to Done in METplus-Wrappers-5.0.0-beta4 (10/26/22) Oct 24, 2022
@georgemccabe georgemccabe changed the title StatAnalysis allow filename template tags in jobs StatAnalysis - Allow filename template tags in jobs Oct 25, 2022
@TaraJensen TaraJensen added the reporting: DTC NOAA R2O NOAA Research to Operations DTC Project label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemccabe georgemccabe

Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: python wrapper METplus: Configuration priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: METplus Team METplus Development Team required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: enhancement Improve something that it is currently doing
Projects
No open projects
METplus-Wrappers-5.0.0-beta4 (10/26/22)
Status: Done
Milestone
METplus-5.0.0
Development

Successfully merging a pull request may close this issue.

Feature 1842 StatAnalysis - multiple issues dtcenter/METplus
2 participants
@TaraJensen @georgemccabe