Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 685 group pytests #1692

Merged
merged 36 commits into from
Jul 14, 2022
Merged

Feature 685 group pytests #1692

merged 36 commits into from
Jul 14, 2022

Commits on Jul 7, 2022

  1. per #685, added custom pytest markers for many tests so we can run gr… 

    …oups of tests in automation to speed things up. removed unused imports from tests and removed parenthesis from assert statements when they are not needed
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    4e2c4bc View commit details
    Browse the repository at this point in the history

  2. per #685, change logic to check if test category is not equal to 'pyt… 

    …est' to does not start with 'pytest' to allow groups of pytests
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    46104ba View commit details
    Browse the repository at this point in the history

  3. per #685, run pytests with markers to subset tests into groups

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b509fee View commit details
    Browse the repository at this point in the history

  4. fixed check if string starts with pytests

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    57c8dde View commit details
    Browse the repository at this point in the history

  5. added missing pytest marker name

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    811b256 View commit details
    Browse the repository at this point in the history

  6. added logic to support running all pytests that do not match a given … 

    …marker with the 'not <marker>' syntax
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    c487568 View commit details
    Browse the repository at this point in the history

  7. change pytest group to wrapper because the test expects another test … 

    …to have run prior to running
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    f5b31da View commit details
    Browse the repository at this point in the history

  8. fix 'not' logic by adding quotation marks around value

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    95ef58e View commit details
    Browse the repository at this point in the history

  9. another approach to fixing not functionality for tests

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3bdab1e View commit details
    Browse the repository at this point in the history

  10. added util marker to more tests

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b66448e View commit details
    Browse the repository at this point in the history

  11. fixed typo in not logic

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6afeaec View commit details
    Browse the repository at this point in the history

  12. added util marker to more tests again

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    aed62bd View commit details
    Browse the repository at this point in the history

  13. fixed logic to split string

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    c6607c3 View commit details
    Browse the repository at this point in the history

  14. marked rest of util tests with util marker

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    831037a View commit details
    Browse the repository at this point in the history

  15. fixed another typo in string splitting logic

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    71eb108 View commit details
    Browse the repository at this point in the history

  16. tested change that should properly split strings

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    166a0a2 View commit details
    Browse the repository at this point in the history

  17. moved wrapper tests into wrapper directory

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    b01dec1 View commit details
    Browse the repository at this point in the history

  18. changed marker for plotting tests

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    0df52e6 View commit details
    Browse the repository at this point in the history

  19. added plotting marker

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    552d2ec View commit details
    Browse the repository at this point in the history

  20. improved logic for removing underscore after 'not' and around 'or' to… 

    … specify more complex marker strings
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    5e96988 View commit details
    Browse the repository at this point in the history

  21. test running group of 3 markers

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    4bf56ae View commit details
    Browse the repository at this point in the history

  22. fixed path the broke when test file was moved into a lower directory

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d8169db View commit details
    Browse the repository at this point in the history

  23. Changed StatAnalysis tests to use plotting marker because some of the… 

    … tests involve plotting but the other StatAnalysis tests produce output that are used in the plotting tests
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    a252858 View commit details
    Browse the repository at this point in the history

  24. changed some tests from marker 'wrapper' to 'wrapper_a' to split up s… 

    …ome of these tests into separate runs
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d9c391a View commit details
    Browse the repository at this point in the history

  25. merged develop and resolved conflicts

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    6e71a21 View commit details
    Browse the repository at this point in the history

  26. test to see if running pytests in single job but split into groups by… 

    … marker will improve the timing enough
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    1f1d0b0 View commit details
    Browse the repository at this point in the history

  27. fixed typos in new logic

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    dc82111 View commit details
    Browse the repository at this point in the history

  28. removed code that is no longer needed (added comment in issue #685 if… 

    … this logic is desired in the future)
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    69b0cce View commit details
    Browse the repository at this point in the history

  29. per #685, divided pytests into smaller groups

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    050c1a2 View commit details
    Browse the repository at this point in the history

  30. added a test that will fail to test that the entire pytest job will f… 

    …ail as expected
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    038d049 View commit details
    Browse the repository at this point in the history

  31. add error message if any pytests failed to help reviewer search for f… 

    …ailed tests
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    23fe0ee View commit details
    Browse the repository at this point in the history

  32. removed failing test after confirming that entire pytest job properly… 

    … reports an error if any test fails
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    e7860cd View commit details
    Browse the repository at this point in the history

  33. turn on single use case group to make sure logic to build matrix of t… 

    …est jobs to run still works as expected
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    3cf5b91 View commit details
    Browse the repository at this point in the history

  34. turn off use case after confirming tests were created properly

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    962cd22 View commit details
    Browse the repository at this point in the history

  35. added documentation to contributor's guide to describe changes to uni… 

    …t test logic
    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    0a4ed3f View commit details
    Browse the repository at this point in the history

  36. added note about adding new pytest markers

    @georgemccabe
    georgemccabe committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d1a3b55 View commit details
    Browse the repository at this point in the history