Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1694 s2s subgroups #1697

Merged
merged 28 commits into from
Jul 18, 2022
Merged

Feature 1694 s2s subgroups #1697

merged 28 commits into from
Jul 18, 2022

Conversation

georgemccabe
Copy link
Collaborator

Change Summary

  • Split s2s use cases into 3 groups (s2s, s2s_mid_lat, and s2s_mjo) to reduce the size of the input data sets to prevent GHA environment disk space issues
  • Added logic recommended by GitHub developers to reduce disk size by removing files that are not needed by us, i.e. android dev tools
  • Renamed convection_allowing_models category to short_range per Change all references from Convection Allowing Models to Short Range #947
  • Modified logic to made repository rename from METdatadb to METdataio
  • Changed exit code for diff tests so that it is easier to determine whether a use case group has failed due to errors in a use case (exit 1) or differences in the output (exit 2)

Pull Request Testing

  • Describe testing already performed for these changes:

Ensured all use cases ran successfully in automated tests

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  • Ensure all failures in automated tests are due to differences because the use case names and numbers have changed.
  • Verify documentation of moved/renamed use cases are correct and formatted properly
  • Check output files that flagged differences and ensure that the output is correct.
    • short_range use cases will correspond to the same number as the old convection_allowing_models equivalent
    • Most of the s2s use case numbers has shifted and some have been moved to new groups. The output should not change except that input/output directories that referenced s2s will now reference the new group names s2s_mid_lat and s2s_mjo for cases moved to those groups
  • Optionally run use cases that have changed locally
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    See above. Diffs will be shown in many use cases because they were renamed/renumbered. The actual output of these use cases should not differ.

  • Please complete this pull request review by 7/18/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…dingly, and turned on all s2s use cases to test that they all run successfully after the changes
…ed other METdbLoad use case to see if that fails as well
…dtcenter/metplus-envs:metdataio Docker image
…t METdatadb rename to METdataio, ci-skip-unit-tests
…use case was likely not related, ci-skip-unit-tests
… case test job failed due to an actual failure or due to differences in the output
…vent warning that artifact contains more than 10,000 files. The 2 WeatherRegime use cases produce a lot of output files, so splitting them up should resolve this warning
@@ -42,7 +42,6 @@ one of the following:

* air_quality_and_comp
* climate
* convection_allowing_models
* data_assimilation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add in "short_range" to replace the "convection_allowing_models".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are looking at the "before" text. This change is removing convection_allowing_models and adding short_range below.

Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output from RMM, OMI, blocking, and weather regime match what they were prior to the change, so this looks good on my end. We may want to uncover the settings to avoid overlapping documentation in the future

… the current version of the documentation to match the quick search links from the METplus User's Guide
… short_range and added note to alert developers that the list of use cases in the script is not maintained and therefore not complete
Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change over for naming and new s2s categories looks to be all set. Documentation looks correct, and any missed references to convection allowing models at least shouldn't break the documentation.

@georgemccabe georgemccabe merged commit a20c0bb into develop Jul 18, 2022
georgemccabe added a commit that referenced this pull request Jul 18, 2022
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: Mrinal Biswas <biswas@ucar.edu>
Co-authored-by: Hank Fisher <fisherh@kiowa.rap.ucar.edu>
Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu>
Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com>
Co-authored-by: Christina Kalb <kalb@kiowa.rap.ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu>
Co-authored-by: Mrinal Biswas <biswas@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: j-opatz <jopatz@ucar.edu>
Co-authored-by: Kathryn Newman <knewman@seneca.rap.ucar.edu>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Co-authored-by: Lisa Goodrich <lisag@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@ucar.edu>
Co-authored-by: Christina Kalb <kalb@mohawk.rap.ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: bikegeek <minnawin@ucar.edu>
Co-authored-by: Hank Fisher <fisherh@ucar.edu>
Co-authored-by: Christina Kalb <kalb@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: Molly Smith <molly.b.smith@noaa.gov>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
@georgemccabe georgemccabe deleted the feature_1694_s2s_subgroups branch July 22, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3 participants