feature #1566 Use Python 3.8.6 for automated tests #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en test to see if use cases that use that env still work using the .v5 version, ci-run-all-diff
…ython 3.8.6 for METplus v5
…nda environments built from Python 3.8.6, ci-run-all-diff
… be consistent in the automation logic and avoid special behavior for those environments
…ently by excluding the version number. Cleaned up logic to add version number extension to conda environment names as needed
…or METdataio (renamed from METdatadb) to use in automated tests for v5
…m weatherregime env
…us into feature_1566_python_3.8.6
…t is installed in the Docker Conda environments used for the automated tests to ensure that the same environment will be generated even if the default version of the package differs from the env used to create them
25 tasks
|
I inspected the differences in the use case "6.2.5.1. Multi_Tool: Feature Relative by Lead using Multiple User-Defined Fields" for the saturation equivalent potential temperature (sept/SEPT) field. These differences were on the order of 3e-5 K, which I consider to be extremely small. I approve. |
DanielAdriaansen
approved these changes
Jul 25, 2022
|
@CPKalb confirmed with me that the changes to the s2s output as acceptable. The images that were generated from the use case are a slightly different size, but the content on the graphs are the same. Merging PR and updating truth data in develop-ref. |
georgemccabe
added a commit
that referenced
this pull request
Jul 26, 2022
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: Mrinal Biswas <biswas@ucar.edu> Co-authored-by: Hank Fisher <fisherh@kiowa.rap.ucar.edu> Co-authored-by: Minna Win <minnawin@kiowa.rap.ucar.edu> Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com> Co-authored-by: Christina Kalb <kalb@kiowa.rap.ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Hank Fisher <fisherh@seneca.rap.ucar.edu> Co-authored-by: Mrinal Biswas <biswas@seneca.rap.ucar.edu> Co-authored-by: jprestop <jpresto@ucar.edu> Co-authored-by: j-opatz <jopatz@ucar.edu> Co-authored-by: Kathryn Newman <knewman@seneca.rap.ucar.edu> Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com> Co-authored-by: Lisa Goodrich <lisag@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: Christina Kalb <kalb@mohawk.rap.ucar.edu> Co-authored-by: bikegeek <minnawin@ucar.edu> Co-authored-by: Hank Fisher <fisherh@ucar.edu> Co-authored-by: Christina Kalb <kalb@ucar.edu> Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: Molly Smith <molly.b.smith@noaa.gov> Co-authored-by: hsoh-u <hsoh@ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Created new Docker images with Conda environments named ending with .v5 that uses Python 3.8.6 instead of Python 3.6.
Ran all use case tests
Confirm that any differences in use cases you are familiar with are expected (we have already discussed these)
Updated instructions to create Conda environments and updated comments in each script to create each env to include the version numbers of the packages that were installed.
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes]
Some small differences were flagged in a few use cases. These are due to slightly differences due to using a different version of some of the Python packages, such as rounding differences and different default size of images
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes