Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix #1713 main_v4.1 METPLOTPY_BASE #1716

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Jul 26, 2022

Pull Request Testing

  • Describe testing already performed for these changes:

Ensured that all use cases that set METPLOTPY_BASE still run successfully (CrossSpectraPlot and Hovmoeller)

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  • Ensure are automated tests pass
  • Review instructions in defaults.conf
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by 7/29/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…config file and instead set it in the global config settings for the automated test environment, ci-run-all-cases
…s] in the default METplus config file upon install if necessary
@georgemccabe georgemccabe added this to the METplus-4.1.3 Bugfix milestone Jul 26, 2022
@georgemccabe georgemccabe linked an issue Jul 26, 2022 that may be closed by this pull request
27 tasks
@bikegeek bikegeek closed this Jul 27, 2022
@bikegeek bikegeek reopened this Jul 27, 2022
@bikegeek bikegeek merged commit 112386a into main_v4.1 Jul 27, 2022
@bikegeek bikegeek deleted the bugfix_1713_main_v4.1_metplotpy_base branch July 27, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Reconcile setting of METPLOTPY_BASE for use cases
2 participants