Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature #1787 allow NA instead of only integers for hour_interval #1788

Merged
merged 2 commits into from
Sep 9, 2022
Merged

feature #1787 allow NA instead of only integers for hour_interval #1788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abc870a
per #1787, allow NA instead of only integers for climo_mean/stdev hou…
georgemccabe Sep 9, 2022
a58b6ad
per #1787, added test for setting NA for climo_mean hour_interval
georgemccabe Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal_tests/pytests/grid_stat/test_grid_stat_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,9 @@ def test_handle_climo_file_variables(metplus_config, config_overrides,
({'GRID_STAT_CLIMO_MEAN_HOUR_INTERVAL': '12', },
{'METPLUS_CLIMO_MEAN_DICT': 'climo_mean = {hour_interval = 12;}'}),

({'GRID_STAT_CLIMO_MEAN_HOUR_INTERVAL': 'NA', },
{'METPLUS_CLIMO_MEAN_DICT': 'climo_mean = {hour_interval = NA;}'}),

({
'GRID_STAT_CLIMO_MEAN_FILE_NAME': '/some/climo_mean/file.txt',
'GRID_STAT_CLIMO_MEAN_FIELD': '{name="CLM_NAME"; level="(0,0,*,*)";}',
Expand Down
2 changes: 1 addition & 1 deletion metplus/wrappers/command_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,7 @@ def handle_climo_dict(self):
'time_interp_method': ('string', 'remove_quotes,uppercase'),
'match_month': ('bool', 'uppercase'),
'day_interval': ('string', 'remove_quotes,uppercase'),
'hour_interval': 'int',
'hour_interval': ('string', 'remove_quotes,uppercase'),
'file_type': ('string', 'remove_quotes'),
}
for climo_type in self.climo_types:
Expand Down