Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #1910 main_v4.1 EnsembleStat level in forecast input template #1911

Merged

Conversation

georgemccabe
Copy link
Collaborator

See #1910 for details.

Pull Request Testing

  • Describe testing already performed for these changes:

Ran a modified version of EnsembleStat.conf basic use case that references {level?fmt=%2H} in the forecast input template and confirmed that it sets it to 0 even if the FCST_VAR1_LEVELS value is not.
Made changes and reran use case to confirm that it works as expected.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Run use case config saved for this PR using the latest release and with the bugfix branch to confirm that the change fixed the issue.

Text file with commands to run can be found on seneca here:
/d1/projects/METplus/pull_requests/METplus-4.1.0/bugfix_1910_main_v4.1/commands_to_run.txt

Run using the v4.1 release found in /usr/local, which should fail
The output will be written to /d1/personal/${USER}/1910-out-main

/usr/local/METplus/ush/run_metplus.py \
/d1/projects/METplus/pull_requests/METplus-4.1.0/bugfix_1910_main_v4.1/EnsembleStat_level.conf \
config.OUTPUT_BASE=/d1/personal/${USER}/1910-out-main

Run using the bugfix branch, which should succeed
The output will be written to /d1/personal/${USER}/1910-out-bugfix

/d1/projects/METplus/pull_requests/METplus-4.1.0/bugfix_1910_main_v4.1/METplus/ush/run_metplus.py \
/d1/projects/METplus/pull_requests/METplus-4.1.0/bugfix_1910_main_v4.1/EnsembleStat_level.conf \
config.OUTPUT_BASE=/d1/personal/${USER}/1910-out-bugfix
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

There was not an easy way to add a unit test for this fix because of the way the code was written. The changes for the develop branch will include a unit test to ensure that the correct behavior occurs

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 11/4/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that I received the same results as the prompt suggested: the v4.1 fails to find any files, while the bugfix branch ran successfully.

@georgemccabe georgemccabe marked this pull request as ready for review November 3, 2022 21:03
@georgemccabe georgemccabe merged commit f89544e into main_v4.1 Nov 3, 2022
@georgemccabe georgemccabe deleted the bugfix_1910_main_v4.1_ensemble_stat_level_in_fcst branch November 3, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Set level properly in filename template for EnsembleStat forecast input
2 participants