Bugfix #1910 main_v4.1 EnsembleStat level in forecast input template #1911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1910 for details.
Pull Request Testing
Ran a modified version of EnsembleStat.conf basic use case that references {level?fmt=%2H} in the forecast input template and confirmed that it sets it to 0 even if the FCST_VAR1_LEVELS value is not.
Made changes and reran use case to confirm that it works as expected.
Run use case config saved for this PR using the latest release and with the bugfix branch to confirm that the change fixed the issue.
Text file with commands to run can be found on seneca here:
/d1/projects/METplus/pull_requests/METplus-4.1.0/bugfix_1910_main_v4.1/commands_to_run.txt
Run using the v4.1 release found in /usr/local, which should fail
The output will be written to /d1/personal/${USER}/1910-out-main
Run using the bugfix branch, which should succeed
The output will be written to /d1/personal/${USER}/1910-out-bugfix
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
There was not an easy way to add a unit test for this fix because of the way the code was written. The changes for the develop branch will include a unit test to ensure that the correct behavior occurs
Will this PR result in changes to the test suite? [No]
Please complete this pull request review by 11/4/2022.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes