Bugfix #1910 develop EnsembleStat level in forecast input template #1919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
I refactored the logic to be consistent about setting field information in filename templates to ensure that all uses of templates will support the correct values.
FCST_VAR1_LEVELS = A06
and a FCST_*_INPUT_TEMPLATE include {fcst_level}, then A06 will be used.FCST_VAR1_LEVELS = A06
and {level?fmt=%3H} is referenced in FCST_ENSEMBLE_STAT_INPUT_TEMPLATE, then the template tag will be substituted with 006. This preserves the previous behavior but ensures it will be available consistently.Pull Request Testing
Added unit tests for correct behavior
Confirmed unit test fails using develop, but succeeds with the updates from this pull request
Confirm all tests pass
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
New tests were added but they should all pass
Please complete this pull request review by 11/14/2022.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes