Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #1898 tc new options #1932

Merged
merged 24 commits into from
Nov 16, 2022
Merged

Commits on Nov 7, 2022

  1. Per #1898, add support for setting optional -diag argument to tc_pair…

    …s, refactored logic to set a/b/edeck arguments to remove unnecessary class variables
    georgemccabe committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    44fc9f5 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. added new fake data files to test that correct commands are built for…

    … multiple calls to tc_pairs
    georgemccabe committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b89885a View commit details
    Browse the repository at this point in the history
  2. cleaned up tests and added check to ensure command is generated corre…

    …ctly when running once processing a directory
    georgemccabe committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    34216c5 View commit details
    Browse the repository at this point in the history
  3. expanded unit tests to check that -diag arguments are set properly an…

    …d that multiple commands are generated properly
    georgemccabe committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    a8c4f02 View commit details
    Browse the repository at this point in the history
  4. per #1898, added support for setting -diag arguments and rearranged f…

    …unctions so they are in a more logical order
    georgemccabe committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b284913 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    748a0dc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a9bd2e2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4ad713f View commit details
    Browse the repository at this point in the history
  8. per #1898, add support for setting diag_name and diag_convert_map in …

    …TCPairs wrapped config file
    georgemccabe committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    eab66e8 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. fixed bug in formatting list of dictionaries in wrapped MET config fi…

    …les, fixed incorrect unit tests, added unit tests to ensure multiple diag_convert_map list items are formatted properly
    georgemccabe committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    756aab7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ea9ee3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c377e30 View commit details
    Browse the repository at this point in the history
  4. added comments to describe each new unit test and number to easily tr…

    …ack down which test fails
    georgemccabe committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    29aed7c View commit details
    Browse the repository at this point in the history
  5. removed tests that shouldn't occur because all 3 items of diag_conver…

    …t_map must be set or MET will error
    georgemccabe committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    b8c3240 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d978916 View commit details
    Browse the repository at this point in the history
  7. Per #1898, added support for diag_thresh_name, diag_thresh_val, init_…

    …diag_thresh_name, and init_diag_thresh_val. Also added support for line_type, event_equal, event_equal_lead, out_init_mask, and valid_init_mask in case those are needed later. Fixed bug where variables ending with 'thresh_val' were not properly formatted without quotation marks. Added unit tests to ensure all env vars are set properly which uncovered some bugs in the logic
    georgemccabe committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    2adc563 View commit details
    Browse the repository at this point in the history
  8. fixed bug where init_inc, init_exc, valid_inc, and valid_exc were not…

    … set from the METplus config
    georgemccabe committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    42f1153 View commit details
    Browse the repository at this point in the history
  9. make tests that check env vars consistent and ensure they check all o…

    …f the variables that should be checked -- fixed StatAnalysis test that was not working properly because of this
    georgemccabe committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    f74152c View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    729961d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    86dbaeb View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Configuration menu
    Copy the full SHA
    9bb6b36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    66092a1 View commit details
    Browse the repository at this point in the history
  3. Per #1898, removed setting of models in -diag arguments because they …

    …are now set in diag_info_map.match_to_track. Added documentation for TC_PAIRS_DIAG_SOURCE<n>, TC_PAIRS_DIAG_DIR<n>, and TC_PAIRS_DIAG_TEMPLATE<n> that was missing
    georgemccabe committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    aa91458 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ff4f62b View commit details
    Browse the repository at this point in the history