Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #1819 alert users if updates to EnsembleStat use cases are needed #1945

Merged
merged 15 commits into from
Nov 16, 2022
Merged

Feature #1819 alert users if updates to EnsembleStat use cases are needed #1945

merged 15 commits into from
Nov 16, 2022

Commits on Nov 10, 2022

  1. per #1819, moved dictionary used to handle deprecated config variable… 

    …s to the constants file, cleaned up the logic to warn if deprecated variables are used, and removed references to [filename_templates] and [dir] sections that are no longer used
    @georgemccabe
    georgemccabe committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    350d4fe View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feature_1819_ensemble_help_update_confs

    @georgemccabe
    georgemccabe committed Nov 10, 2022
    Configuration menu
    Copy the full SHA
    6e305e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. removed old deprecated variable checks that are no longer needed, cle… 

    …aned up deprecated checks to no longer require section header names because they should all be [config] now, removed list of deprecated variables that are from very old versions since they should already be updated by users at this point
    @georgemccabe
    georgemccabe committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    773f95f View commit details
    Browse the repository at this point in the history

  2. added more deprecated config variables that have moved from EnsembleS… 

    …tat to GenEnsProd
    @georgemccabe
    georgemccabe committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    db73998 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into feature_1819_ensemble_help_update_confs

    @georgemccabe
    georgemccabe committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    3b29d5a View commit details
    Browse the repository at this point in the history

  4. minor change to trigger ci-run-all-cases

    @georgemccabe
    georgemccabe committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    22ab4f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. per #1819, add logic to deprecated config checks to log additional in… 

    …formation (like a link to the upgrade instructions in the User's Guide) if certain deprecated variables are found. Added path to logfile to screen output if deprecated check fails. Emptied deprecated MET config variable list because they correspond to a very old version. Removed logic to check for deprecated output_prefix settings that are from a very old version
    @georgemccabe
    georgemccabe committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    35798a7 View commit details
    Browse the repository at this point in the history

  2. cleaned up logic for checking for deprecated configs to avoid returni… 

    …ng too many values from validate_configuration_variables function to match pep8 standards and increase readability
    @georgemccabe
    georgemccabe committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0c66f1b View commit details
    Browse the repository at this point in the history

  3. split up config_metplus into 3 files so the utils are easier to navigate

    @georgemccabe
    georgemccabe committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    2a3cec3 View commit details
    Browse the repository at this point in the history

  4. print stack trace if error in code occurs during setup

    @georgemccabe
    georgemccabe committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    1c76559 View commit details
    Browse the repository at this point in the history

  5. moved more functions out of config_metplus

    @georgemccabe
    georgemccabe committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    7e9aba3 View commit details
    Browse the repository at this point in the history

  6. allow replace_config_from_section function to be imported directly, c… 

    …i-run-all-diff
    @georgemccabe
    georgemccabe committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0f1e35a View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. per #1819, added instructions to update use cases that use EnsembleSt… 

    …at -- the content is unformatted but this will be done before the official release
    @georgemccabe
    georgemccabe committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    94e5540 View commit details
    Browse the repository at this point in the history

  2. changed URL to develop instead of latest so the link will work for be… 

    …ta5 users. We will update the link before the release
    @georgemccabe
    georgemccabe committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    9aa118a View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Dan Adriaansen <dadriaan@ucar.edu>
    @georgemccabe @DanielAdriaansen
    georgemccabe and DanielAdriaansen committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    5b9edaa View commit details
    Browse the repository at this point in the history