Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors - slash in branch name and Python version #1983

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

georgemccabe
Copy link
Collaborator

These changes are needed to fix some deficiencies discovered by pull request #1982 that was auto generated by dependabot.

Change Summary

  • Replace / with _ to prevent errors creating docker tags for tests
  • Update version of Python used in GitHub Actions workflow files because 3.6 appears to no longer be supported

Note: There is no branch associated with these changes and I did not assign a milestone because these changes are internal and it is not necessary to include it in the bugfix release notes.

Pull Request Testing

  • Describe testing already performed for these changes:

Named branch with forward slash to test that it properly triggers the testing workflow

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Ensure all automated tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 12/9/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. I see that all tests passed. Inspecting the code, I see the changes described: switching embedding '/' to '_' and updating from python 3.6 to 3.8.

@georgemccabe georgemccabe merged commit 2418b39 into main_v4.1 Dec 9, 2022
@georgemccabe georgemccabe deleted the feature_na/fix_ci_slash_py3.6 branch December 9, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants