Bugfix #2015 main v5.0 modulefiles #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
georgemccabe
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
These changes involve adding new module files that are used to run on various machines. I approve but have a small, optional suggestion for improvement. If possible you could use variables to control the version numbers in files where you have to change the version multiple times. I know you will have to create a new file for each version but at least you would have fewer changes to make.
| ## METplus | ||
| ## | ||
| proc ModulesHelp { } { | ||
| puts stderr "Sets up the paths and environment variables to use the METplus-4.1.1. |
There was a problem hiding this comment.
Incorrect version numbers. Should be 5.0.0 instead of 4.1.1
georgemccabe
requested changes
Jan 25, 2023
jprestop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Used these modulefiles to set up the environment for users on various machines
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None. Review files if desired.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [N/A]
Do these changes include sufficient testing updates? [N/A]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [20230131].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
NOTE: No applicable MET Project available, chose METplus Version 5.0 Support as an umbrella project.
Select: Milestone as the version that will include these changes