Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2026 main_v5.0 StatAnalysis run once per valid time #2027

Merged
merged 6 commits into from
Jan 27, 2023

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Jan 26, 2023

Pull Request Testing

  • Describe testing already performed for these changes:

Ran modified StatAnalysis.conf use case to verify that expected values are set. Confirmed all tests pass

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Run use case that was not running as expected and confirm that changes have fixed the issue.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 01/27/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…_ONCE and added logic to set runtime frequency to once per init/valid if LOOP_ORDER=times and start/end times are not equal to warn users that LOOP_ORDER has been deprecated
…looping over init or valid times, set DATE_BEG/END to the run time so that fcst/obs_init/valid_beg/end are set using the YYYYMMDD of the run time (preserves previous behavior)
@georgemccabe georgemccabe added this to the METplus-5.0.1 Bugfix milestone Jan 26, 2023
@georgemccabe georgemccabe linked an issue Jan 26, 2023 that may be closed by this pull request
23 tasks
@georgemccabe georgemccabe marked this pull request as ready for review January 26, 2023 20:48
Copy link

@ShannonShields-NOAA ShannonShields-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix was successfully tested by Shannon Shields on Hera on Jan. 26, 2023.
First, GridStat was run to generate GEFS stat files under the following directories (to mimic EVS subseasonal weekly average stat output structure): atmos.20221221, atmos.20221228, atmos.20230104, atmos.20230111, atmos.20230118. A StatAnalysis_evstest.conf file was then created/run to loop over these dates and gather the stat files under the respective GEFS.20221221, GEFS.20221228, GEFS.20230104, GEFS.20230111, and GEFS.20230118 directories. Setting STAT_ANALYSIS_RUNTIME_FREQ = RUN_ONCE_PER_INIT_OR_VALID in the config file allowed the wrapper to loop over each valid time. If this is not set, then the runtime frequency setting defaults to RUN_ONCE, and the user is reminded to set STAT_ANALYSIS_RUNTIME_FREQ to override.
If LOOP_ORDER=times is set and VALID_BEG is not the same as VALID_END, then a warning message appears telling the user to set the runtime frequency:
"WARNING: LOOP_ORDER has been deprecated. Please set STAT_ANALYSIS_RUNTIME_FREQ = RUN_ONCE_PER_INIT_OR_VALID instead."
The config and log files can be found at:
/scratch2/NCEPDEV/stmp1/Shannon.Shields/scripts/s2s/repo_scripts/METplus/StatAnalysis_evstest.conf
/scratch2/NCEPDEV/stmp1/Shannon.Shields/scripts/s2s/cases/logs/StatAnalysis_fcstGEFS_for20230118_runon20230127024434.log

@georgemccabe georgemccabe merged commit aa9d7b3 into main_v5.0 Jan 27, 2023
@georgemccabe georgemccabe deleted the bugfix_2026_main_v5.0_stat_analysis_loop branch January 27, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Bugfix: StatAnalysis - allow run once for each valid time
2 participants