Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix #2189 develop - spaces in complex thresholds #2191

Merged
merged 5 commits into from
May 31, 2023
Merged

Bugfix #2189 develop - spaces in complex thresholds #2191

merged 5 commits into from
May 31, 2023

Commits on May 31, 2023

  1. cleanup

    @georgemccabe
    georgemccabe committed May 31, 2023
    Configuration menu
    Copy the full SHA
    771e32e View commit details
    Browse the repository at this point in the history

  2. pass (optional) logger to threshold check functions to properly log a… 

    …n error instead of printing to console
    @georgemccabe
    georgemccabe committed May 31, 2023
    Configuration menu
    Copy the full SHA
    b314e0b View commit details
    Browse the repository at this point in the history

  3. per #2189, added unit test to recreate bug where spaces around && or … 

    …|| cause the threshold to be rejected as invalid
    @georgemccabe
    georgemccabe committed May 31, 2023
    Configuration menu
    Copy the full SHA
    0698bef View commit details
    Browse the repository at this point in the history

  4. per #2189, remove whitespace around threshold values to fix bug that … 

    …rejects complex thresholds with whitespace around && or ||
    @georgemccabe
    georgemccabe committed May 31, 2023
    Configuration menu
    Copy the full SHA
    31d9906 View commit details
    Browse the repository at this point in the history

  5. per #2189, added thresholds that demonstrate bug to the GridStat unit… 

    … tests to ensure it is formatted properly
    @georgemccabe
    georgemccabe committed May 31, 2023
    Configuration menu
    Copy the full SHA
    33485bf View commit details
    Browse the repository at this point in the history