Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix diff tests #2217

Merged
merged 19 commits into from
Jun 16, 2023
Merged

Bugfix diff tests #2217

merged 19 commits into from
Jun 16, 2023

Commits on Jun 14, 2023

  1. update diff util and test that changes properly diff failling diffs, … 

    …ci-run-diff
    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2c0332a View commit details
    Browse the repository at this point in the history

  2. turn off use case

    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    905b409 View commit details
    Browse the repository at this point in the history

  3. catch any exception that occurs in NetCDF file diff, ci-skip-unit-tests

    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c2b6e3a View commit details
    Browse the repository at this point in the history

  4. catch any exception from file diff instead of just in NetCDF diff, ci… 

    …-skip-unit-tests
    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    5fdee80 View commit details
    Browse the repository at this point in the history

  5. forgot to trigger diff, ci-run-diff, ci-skip-unit-tests

    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    21af4b2 View commit details
    Browse the repository at this point in the history

  6. use pandas.isnull instead of numpy.isnan to prevent exceptions from o… 

    …ccurring, ci-run-diff, ci-skip-unit-tests
    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    2172134 View commit details
    Browse the repository at this point in the history

  7. capture failure in diff script, ci-run-diff, ci-skip-unit-tests

    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    eefaa0c View commit details
    Browse the repository at this point in the history

  8. ignore .idea directory that was auto-generated

    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0201daa View commit details
    Browse the repository at this point in the history

  9. fix incorrect syntax, ci-run-diff, ci-skip-unit-tests

    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    194088d View commit details
    Browse the repository at this point in the history

  10. handle failing comparison when NetCDF values are stored as a string, … 

    …ci-run-diff, ci-skip-unit-tests
    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    8017d99 View commit details
    Browse the repository at this point in the history

  11. Preserve backwards compatibility by forcing TC_PAIRS_RUN_ONCE=False i… 

    …f LOOP_ORDER is still used and warn that it should be removed. Add debug log message to alert user that only the first init/valid time is being processed and how to change that if desired
    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    d7981f2 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'bugfix_gha_diff' of github.com:dtcenter/METplus into bu… 

    …gfix_gha_diff
    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    edbbe39 View commit details
    Browse the repository at this point in the history

  13. add pandas to diff conda environment used for diff tests in GHA to pr… 

    …operly check for null/NaN values
    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c8a80b2 View commit details
    Browse the repository at this point in the history

  14. turn off use cases after tests succeeded

    @georgemccabe
    georgemccabe committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    353fd15 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. update apt-get to fix poppler-utils install error, add specific versi… 

    …on for pandas
    @georgemccabe
    georgemccabe committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    52f5ceb View commit details
    Browse the repository at this point in the history

  2. run use case to test that diff.v5.1 conda env was created properly, c… 

    …i-run-diff
    @georgemccabe
    georgemccabe committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    1421c18 View commit details
    Browse the repository at this point in the history

  3. check if values are completely equal inside _is_equal_rounded functio… 

    …n, call that function in NC value diff to prevent differences that are smaller than 5 decimal places
    @georgemccabe
    georgemccabe committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    b29a7ac View commit details
    Browse the repository at this point in the history

  4. turn off all use case groups before re-opening PR

    @georgemccabe
    georgemccabe committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    2b9bea5 View commit details
    Browse the repository at this point in the history

  5. if both netcdf values are masked, consider them equal

    @georgemccabe
    georgemccabe committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    0cbcff2 View commit details
    Browse the repository at this point in the history