Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #2244 develop fix diff tests #2254

Merged
merged 42 commits into from
Jul 18, 2023

Commits on Jul 12, 2023

  1. set shallow=False for file comparision because shallow compare can in…

    …correctly consider 2 files equal when their content is not
    georgemccabe committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f4e6e78 View commit details
    Browse the repository at this point in the history
  2. pop header line from file b that was incorrectly removed, add check t…

    …o error if header values differ
    georgemccabe committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    670cabf View commit details
    Browse the repository at this point in the history
  3. remove header from zip so additional columns in stat files past the l…

    …ength of the header columns are still compared, ci-run-all-diff
    georgemccabe committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8cbf350 View commit details
    Browse the repository at this point in the history
  4. error if different number of columns in stat files, include column nu…

    …mber to easily identify which columns differ, various clean up
    georgemccabe committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    8b2fc0e View commit details
    Browse the repository at this point in the history
  5. ci-run-all-diff

    georgemccabe committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    998fd47 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. change log messages to discern which test determined no diffs, turn o…

    …n pbl use case to test expected failure, ci-run-diff
    georgemccabe committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    f1898b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8207e4b View commit details
    Browse the repository at this point in the history
  3. refactor to move logic into function, return non-zero if diffs occur …

    …when running diff script directly
    georgemccabe committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    6de3620 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6c8f5f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6890dc3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a1caa8a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    15711ff View commit details
    Browse the repository at this point in the history
  8. per #2245, use unique run ID to name logger instance to ensure that c…

    …oncurrent runs do not use the same logger instance
    georgemccabe committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    83b2494 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. per #2249, add a step to Dockerfiles to remove the conda environment …

    …that was used to create a new environment to free up space
    georgemccabe committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    da6e5b1 View commit details
    Browse the repository at this point in the history
  2. create test.v5.1 metplus-env docker image to use for both pytests and…

    … diff tests since the pytests will require the packages needed for the diff tests to properly unit test diff_util
    georgemccabe committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    577147d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    723a574 View commit details
    Browse the repository at this point in the history
  4. updated comparison that includes rounding to properly handle strings …

    …by checking if the value is numeric
    georgemccabe committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    5a9548a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    159493b View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. per #2245, add METplusConfig class function that is called when objec…

    …t is deleted to close log handlers. This prevents OSError: [Errno 24] Too many open files from running all pytests
    georgemccabe committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    d5ea70c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a27a2e View commit details
    Browse the repository at this point in the history
  3. add doc info

    georgemccabe committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    47795f4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a9622df View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0e8e7d4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c0ad3e4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8b599de View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f30277b View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    93d26e6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    457987c View commit details
    Browse the repository at this point in the history
  11. update logic to allow wrapper to initialize properly if R scripts do …

    …not need to be present -- for unit tests and running METplus without executing commands
    georgemccabe committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8bb277e View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Removed logic to require minimum_pytest.<host>.sh script to run pytes…

    …ts. Instead require METPLUS_TEST_OUTPUT_BASE to be set in the user's environment to run tests. Add logic to ensure that the output base is writable by the user running the pytests or alert user before tests start to run
    georgemccabe committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e1dd5c6 View commit details
    Browse the repository at this point in the history
  2. error and exit if output base is set to a directory where the user do…

    …es not have write permissions
    georgemccabe committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    702352a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    01bfe21 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3e6616a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    596a8ef View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    26562d5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3b906a3 View commit details
    Browse the repository at this point in the history
  8. remove file containing pytest groups because they are no longer requi…

    …red to run all of the tests
    georgemccabe committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    59de5c9 View commit details
    Browse the repository at this point in the history
  9. add diff marker to be able to run all unit tests except the diff util…

    …ity tests that have additional dependencies that may not be available on all systems
    georgemccabe committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    0982a55 View commit details
    Browse the repository at this point in the history
  10. per #2244, updated documentation about running unit tests. removed se…

    …ction about running use case tests because they are typically run in GitHub Actions instead of locally. Use case tests can still be run manually by running a use case and writing output to 2 different directories, then comparing the results
    georgemccabe committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    d3033c6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c147404 View commit details
    Browse the repository at this point in the history
  12. set DO_NOT_RUN_EXE for all tests to prevent the actual commands from …

    …running unless explicitly specified
    georgemccabe committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    10ae204 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    e2db1cf View commit details
    Browse the repository at this point in the history