-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix #2244 develop fix diff tests #2254
Commits on Jul 12, 2023
-
set shallow=False for file comparision because shallow compare can in…
…correctly consider 2 files equal when their content is not
Configuration menu - View commit details
-
Copy full SHA for f4e6e78 - Browse repository at this point
Copy the full SHA f4e6e78View commit details -
pop header line from file b that was incorrectly removed, add check t…
…o error if header values differ
Configuration menu - View commit details
-
Copy full SHA for 670cabf - Browse repository at this point
Copy the full SHA 670cabfView commit details -
remove header from zip so additional columns in stat files past the l…
…ength of the header columns are still compared, ci-run-all-diff
Configuration menu - View commit details
-
Copy full SHA for 8cbf350 - Browse repository at this point
Copy the full SHA 8cbf350View commit details -
error if different number of columns in stat files, include column nu…
…mber to easily identify which columns differ, various clean up
Configuration menu - View commit details
-
Copy full SHA for 8b2fc0e - Browse repository at this point
Copy the full SHA 8b2fc0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 998fd47 - Browse repository at this point
Copy the full SHA 998fd47View commit details
Commits on Jul 13, 2023
-
change log messages to discern which test determined no diffs, turn o…
…n pbl use case to test expected failure, ci-run-diff
Configuration menu - View commit details
-
Copy full SHA for f1898b3 - Browse repository at this point
Copy the full SHA f1898b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8207e4b - Browse repository at this point
Copy the full SHA 8207e4bView commit details -
refactor to move logic into function, return non-zero if diffs occur …
…when running diff script directly
Configuration menu - View commit details
-
Copy full SHA for 6de3620 - Browse repository at this point
Copy the full SHA 6de3620View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6c8f5f - Browse repository at this point
Copy the full SHA e6c8f5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6890dc3 - Browse repository at this point
Copy the full SHA 6890dc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1caa8a - Browse repository at this point
Copy the full SHA a1caa8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15711ff - Browse repository at this point
Copy the full SHA 15711ffView commit details -
per #2245, use unique run ID to name logger instance to ensure that c…
…oncurrent runs do not use the same logger instance
Configuration menu - View commit details
-
Copy full SHA for 83b2494 - Browse repository at this point
Copy the full SHA 83b2494View commit details
Commits on Jul 14, 2023
-
per #2249, add a step to Dockerfiles to remove the conda environment …
…that was used to create a new environment to free up space
Configuration menu - View commit details
-
Copy full SHA for da6e5b1 - Browse repository at this point
Copy the full SHA da6e5b1View commit details -
create test.v5.1 metplus-env docker image to use for both pytests and…
… diff tests since the pytests will require the packages needed for the diff tests to properly unit test diff_util
Configuration menu - View commit details
-
Copy full SHA for 577147d - Browse repository at this point
Copy the full SHA 577147dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 723a574 - Browse repository at this point
Copy the full SHA 723a574View commit details -
updated comparison that includes rounding to properly handle strings …
…by checking if the value is numeric
Configuration menu - View commit details
-
Copy full SHA for 5a9548a - Browse repository at this point
Copy the full SHA 5a9548aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 159493b - Browse repository at this point
Copy the full SHA 159493bView commit details
Commits on Jul 17, 2023
-
per #2245, add METplusConfig class function that is called when objec…
…t is deleted to close log handlers. This prevents OSError: [Errno 24] Too many open files from running all pytests
Configuration menu - View commit details
-
Copy full SHA for d5ea70c - Browse repository at this point
Copy the full SHA d5ea70cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a27a2e - Browse repository at this point
Copy the full SHA 5a27a2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 47795f4 - Browse repository at this point
Copy the full SHA 47795f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9622df - Browse repository at this point
Copy the full SHA a9622dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e8e7d4 - Browse repository at this point
Copy the full SHA 0e8e7d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0ad3e4 - Browse repository at this point
Copy the full SHA c0ad3e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b599de - Browse repository at this point
Copy the full SHA 8b599deView commit details -
Configuration menu - View commit details
-
Copy full SHA for f30277b - Browse repository at this point
Copy the full SHA f30277bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 93d26e6 - Browse repository at this point
Copy the full SHA 93d26e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 457987c - Browse repository at this point
Copy the full SHA 457987cView commit details -
update logic to allow wrapper to initialize properly if R scripts do …
…not need to be present -- for unit tests and running METplus without executing commands
Configuration menu - View commit details
-
Copy full SHA for 8bb277e - Browse repository at this point
Copy the full SHA 8bb277eView commit details
Commits on Jul 18, 2023
-
Removed logic to require minimum_pytest.<host>.sh script to run pytes…
…ts. Instead require METPLUS_TEST_OUTPUT_BASE to be set in the user's environment to run tests. Add logic to ensure that the output base is writable by the user running the pytests or alert user before tests start to run
Configuration menu - View commit details
-
Copy full SHA for e1dd5c6 - Browse repository at this point
Copy the full SHA e1dd5c6View commit details -
error and exit if output base is set to a directory where the user do…
…es not have write permissions
Configuration menu - View commit details
-
Copy full SHA for 702352a - Browse repository at this point
Copy the full SHA 702352aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01bfe21 - Browse repository at this point
Copy the full SHA 01bfe21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e6616a - Browse repository at this point
Copy the full SHA 3e6616aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 596a8ef - Browse repository at this point
Copy the full SHA 596a8efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26562d5 - Browse repository at this point
Copy the full SHA 26562d5View commit details -
add more tests for csv and stat files. move multiple tests into a sin…
…gle parameterized test
Configuration menu - View commit details
-
Copy full SHA for 3b906a3 - Browse repository at this point
Copy the full SHA 3b906a3View commit details -
remove file containing pytest groups because they are no longer requi…
…red to run all of the tests
Configuration menu - View commit details
-
Copy full SHA for 59de5c9 - Browse repository at this point
Copy the full SHA 59de5c9View commit details -
add diff marker to be able to run all unit tests except the diff util…
…ity tests that have additional dependencies that may not be available on all systems
Configuration menu - View commit details
-
Copy full SHA for 0982a55 - Browse repository at this point
Copy the full SHA 0982a55View commit details -
per #2244, updated documentation about running unit tests. removed se…
…ction about running use case tests because they are typically run in GitHub Actions instead of locally. Use case tests can still be run manually by running a use case and writing output to 2 different directories, then comparing the results
Configuration menu - View commit details
-
Copy full SHA for d3033c6 - Browse repository at this point
Copy the full SHA d3033c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c147404 - Browse repository at this point
Copy the full SHA c147404View commit details -
set DO_NOT_RUN_EXE for all tests to prevent the actual commands from …
…running unless explicitly specified
Configuration menu - View commit details
-
Copy full SHA for 10ae204 - Browse repository at this point
Copy the full SHA 10ae204View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2db1cf - Browse repository at this point
Copy the full SHA e2db1cfView commit details