Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance METviewer to plot statistics added to the ECNT, VL1L2, VAL1L2, and VCNT line types introduced in the MET 12.0.0 beta4 development cycle #517

Closed
10 of 25 tasks
JohnHalleyGotway opened this issue Feb 14, 2024 · 3 comments · Fixed by #544
Closed
10 of 25 tasks

Enhance METviewer to plot statistics added to the ECNT, VL1L2, VAL1L2, and VCNT line types introduced in the MET 12.0.0 beta4 development cycle #517

JohnHalleyGotway opened this issue Feb 14, 2024 · 3 comments · Fixed by #544
Assignees
@bikegeek
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METviewer: Statistics METviewer: User Interface priority: blocker Blocker required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone
METviewer-6.0.0

Comments

@JohnHalleyGotway
Copy link
Contributor

JohnHalleyGotway commented Feb 14, 2024 •
edited
Loading

Describe the Enhancement

Issue dtcenter/METdataio#282 updates the schema to load new wind direction statistics from the VL1L2, VAL1L2, and VCNT line types and new ignorance score statistics to the ECNT line type for MET version 12.0.0 . This issue is to update METviewer to provide access to these new statistics both via the web interface and through the backend XML files, as needed.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing priority: blocker Blocker alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METviewer: Statistics METviewer: User Interface labels Feb 14, 2024
@JohnHalleyGotway JohnHalleyGotway added this to the METviewer-6.0.0 milestone Feb 14, 2024
This was referenced Feb 14, 2024
Closed
Closed
Closed
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance METviewer to plot new wind direction statistics in the VL1L2, VAL1L2, and VCNT line types Enhance METviewer to plot statistics added to the ECNT, VL1L2, VAL1L2, and VCNT line types during the MET 12.0.0 beta4 development cycle Mar 14, 2024
@bikegeek bikegeek self-assigned this Apr 4, 2024
@bikegeek
Copy link
Collaborator

add the new columns in the java/src/edu/ucar/metviewer/MVUtil.java code:

ECNT: IGN_CONV_OERR, IGN_CORR_OERR

VL1L2: DIR_ME, DIR_MAE, DIR_MSE
VAL1L2: DIRA_ME, DIRA_MAE, DIRA_MSE
VCNT: DIR_ME, DIR_MAE, DIR_MSE, DIR_ME_BCL, DIR_ME_BCU, DIR_MAE_BCL, DIR_MAE_BCU, DIR_MSE_BCL, DIR_MSE_BCU

bikegeek added a commit that referenced this issue Jul 29, 2024
@bikegeek
Issue #517 Added new columns for the VCNT, VL1L2, VAL1L2, and ECNT li…
0b4714f 
…netypes
@bikegeek bikegeek moved this from 🔖 Ready to 🏗 In progress in METplus-Analysis-6.0.0 Development Jul 31, 2024
@bikegeek
Copy link
Collaborator

bikegeek commented Aug 13, 2024 •
edited
Loading

The scorecard code also required updating: scorecard.db.AggDatabaseManagerMySQL.java for the VL1L2, VAL1L2, and ECNT linetypes. According to the METviewer documentation, there is no support for VCNT which is consistent with the code as support for VCNT is not available in this method.

@bikegeek
Copy link
Collaborator

Added boolAggVcnt=#<agg_vcnt>#; to the agg_stat_info_tmpl

bikegeek added a commit that referenced this issue Aug 13, 2024
@bikegeek
Issue #517 removed the VCNT boostrap variables from statsVcnt
29f2daf
bikegeek added a commit that referenced this issue Aug 13, 2024
@bikegeek
Issue #517 reformatted code and added columns for the VL1L2, VAL1L2, …
cbebd85 
…and ECNT linetypes.
bikegeek added a commit that referenced this issue Aug 13, 2024
@bikegeek
issue #517 fixed entries for VCNT, copy and paste resulted in VAL1L2 …
237af14 
…values instead of VCNT values.
@bikegeek bikegeek moved this from 🏗 In progress to 🔎 In review in METplus-Analysis-6.0.0 Development Aug 22, 2024
@bikegeek bikegeek moved this from 🔎 In review to 🏁 Done in METplus-Analysis-6.0.0 Development Aug 29, 2024
bikegeek added a commit that referenced this issue Aug 29, 2024
@bikegeek
Issue #517 Added new columns for the VCNT, VL1L2, VAL1L2, and ECNT li… (
0b8fda6 
#544)

* Issue #517 Added new columns for the VCNT, VL1L2, VAL1L2, and ECNT linetypes

* Issue #517 removed the VCNT boostrap variables from statsVcnt

* Issue #517 reformatted code and added columns for the VL1L2, VAL1L2, and ECNT linetypes.

* issue #517 fixed entries for VCNT, copy and paste resulted in VAL1L2 values instead of VCNT values.

* Updated the job.getAggEcnt(), job.getAggVl1l2(), and job.getAggVal1l2() to include the new columns.

* Add missing commas between entries in job.getAggEcnt, job.getAggVl1l2, and job.getAggVal1l2

* Add VERSION to statVl1l2.put to be consistent with the agg stat code in  MysqlAppDatabaseManager.java

* Revert back to previous version of statsVl1L2.put, omitting the addition of VL1L2_VERSION, this is not necessary
@bikegeek bikegeek linked a pull request Sep 12, 2024 that will close this issue
Issue #517 Added new columns for the VCNT, VL1L2, VAL1L2, and ECNT li… #544
Merged
14 tasks
@bikegeek bikegeek changed the title Enhance METviewer to plot statistics added to the ECNT, VL1L2, VAL1L2, and VCNT line types during the MET 12.0.0 beta4 development cycle Enhance METviewer to plot statistics added to the ECNT, VL1L2, VAL1L2, and VCNT line types introduced in the MET 12.0.0 beta4 development cycle Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METviewer: Statistics METviewer: User Interface priority: blocker Blocker required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
No open projects
METplus-Analysis-6.0.0 Development
Status: 🏁 Done
Milestone
METviewer-6.0.0
Development

Successfully merging a pull request may close this issue.

Issue #517 Added new columns for the VCNT, VL1L2, VAL1L2, and ECNT li… dtcenter/METviewer
2 participants
@bikegeek @JohnHalleyGotway