Add sorting on totals #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
Jul 9, 2018
src/main.rs
Outdated
| bin: Option<String>, | ||
|
|
||
| /// Set the sort order to number of instantiations | ||
| #[structopt(short = "i", long = "sort-insts")] |
There was a problem hiding this comment.
Please pick a different name for this flag. "Inst" commonly stands for "instruction" not "instantiation", especially in the context of LLVM. For example InstCombine, MCInst, RISCVInstPrinter.
There was a problem hiding this comment.
Sure, any suggestions? I have very little opinion on this
There was a problem hiding this comment.
Bloaty has a -s <sortby> flag which seems reasonable to me. In our case it could be -s lines (the default) or -s copies with long equivalents --sort=lines and --sort=copies.
|
I published 0.1.4 with this flag. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1
Also switched to structopt for commandline parsing and ran the formatter