Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify c++ standard flag for msvc #205

Closed
wants to merge 1 commit into from
Closed

specify c++ standard flag for msvc #205

wants to merge 1 commit into from

Conversation

philipcraig
Copy link
Contributor

No description provided.

@philipcraig
Copy link
Contributor Author

philipcraig commented May 12, 2020

I can see that it's only the four builds on nightly that are failing, and I can reproduce this locally on nightly. stable is fine.

Note that the failed build is not because of trying to include the Windows flag support, but by trying to push the C++ version feature flags so that they are visible to the test suite's build.rs command. I guess as a workaround we could force the test suite to always use a particular C++ version and not worry about allowing a C++ version feature for the test suite?

I'm not clear if it's a bug/stricter nightly requirement or a nightly regression though. Tempted to leave this open a few days and see if nightly fixes this.

It looks like another instance of rust-lang/cargo#6941, which leads to an open bug raised by @dtolnay here rust-lang/cargo#6915

The cargo bugs mention that part of the issue may be that cxx-test-suite is in dev-dependencies

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented an alternate solution in #268 which avoids the Cargo dependency resolution bug. Thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants