Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WASM std targets. #106

Closed
wants to merge 9 commits into from
Closed

Conversation

gkgoat1
Copy link

@gkgoat1 gkgoat1 commented Nov 23, 2024

This PR adds (currently untested) WASM std target support, which rely on an external linker, specified in WASM.md.

@gkgoat1
Copy link
Author

gkgoat1 commented Nov 23, 2024

Note that, currently, WASM support from this PR also has a much higher MSRV.

Update: I fixed the MSRV.

@gkgoat1 gkgoat1 marked this pull request as ready for review November 23, 2024 17:51
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This is different enough from what the rest of the crate does that I prefer if you would publish this in a different crate for now. I am interested to see if others find this usable.

@dtolnay dtolnay closed this Nov 23, 2024
@gkgoat1
Copy link
Author

gkgoat1 commented Nov 23, 2024

Thanks for the PR!

This is different enough from what the rest of the crate does that I prefer if you would publish this in a different crate for now. I am interested to see if others find this usable.

Okay, published. I can wait until there becomes a need before submitting a followup PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants