Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing macOS slice #46

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Fix missing macOS slice #46

merged 2 commits into from
Jan 10, 2022

Conversation

nvzqz
Copy link
Contributor

@nvzqz nvzqz commented Jan 9, 2022

This adds the S_ATTR_NO_DEAD_STRIP section attribute, which forces "unused" code to remain in the binary. This is paired with S_REGULAR to provide a required section type.

This fixes #41.

nvzqz and others added 2 commits January 9, 2022 17:20
This adds the `S_ATTR_NO_DEAD_STRIP` section attribute, which forces
"unused" code to remain in the binary. This is paired with `S_REGULAR`
to provide a required section type.

This fixes dtolnay#41.
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I confirmed that the macOS CI does not work prior to this PR (3bdb745) and does work after this PR (e6f6d1c). Thank you!

@dtolnay dtolnay merged commit 554bbc4 into dtolnay:master Jan 10, 2022
@dtolnay
Copy link
Owner

dtolnay commented Jan 10, 2022

Published in 0.2.9.

@nvzqz nvzqz deleted the fix-macos branch January 10, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS build is failing: SLICE.is_empty()
2 participants