Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize for rustc 1.20+ which can match ident faster #91

Closed
wants to merge 1 commit into from
Closed

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Jan 9, 2019

This performs about 10% better on my machine: the included benchmark is down from 160 microseconds to 144 microseconds.

Mentioning @nnethercote regarding dtolnay/proc-macro2#94 (comment) -- would you like to try this commit in the rustc-perf benchmark before merging?

@mystor
Copy link
Collaborator

mystor commented Jan 9, 2019

If we're up for optimizing for more recent versions this way, I wonder if we should implement quote! as a proc macro on sufficiently recent versions for perf.

@dtolnay
Copy link
Owner Author

dtolnay commented Jan 9, 2019

I would welcome a PR that implements quote as a proc macro to benchmark against.

@dtolnay
Copy link
Owner Author

dtolnay commented Mar 20, 2019

Abandoning because I would prefer not to land this more complicated implementation in the absence of rustc-perf numbers measuring an improvement.

@dtolnay dtolnay closed this Mar 20, 2019
@dtolnay dtolnay deleted the opt branch March 20, 2019 22:05
@nnethercote
Copy link
Contributor

@dtolnay: I apologize for not responding to this back in January. I just tried the patch but it has bitrotted. Would you be able to create a new version? I will be able to benchmark it against rustc-perf if you do. Thanks.

@dtolnay
Copy link
Owner Author

dtolnay commented Oct 11, 2019

@nnethercote sure thing, here's the PR: #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants