-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to use MSRV from rust-version field #70
Comments
I would prefer not to support this. |
Can we ask why or for a re-consider? Obviously this might not be the default, but having some option to use the MSRV toolchain specified in the Cargo would add some consistency to CI runs that specifically test whether the named MSRV is working. Having to maintain the same version in two places to test it is not ideal. For example I just saw this come up here: |
Everything in actions-rs seems to be abandoned so also switching to the dtolnay/rust-toolchain action, but per dtolnay/rust-toolchain#70 apparently it will not support getting MSRV directly so currently that is duplicated in CI, which is not ideal but whatever.
Everything in actions-rs seems to be abandoned so also switching to the dtolnay/rust-toolchain action, but per dtolnay/rust-toolchain#70 apparently it will not support getting MSRV directly so currently that is duplicated in CI, which is not ideal but whatever.
Everything in actions-rs seems to be abandoned so also switching to the dtolnay/rust-toolchain action, but per dtolnay/rust-toolchain#70 apparently it will not support getting MSRV directly so currently that is duplicated in CI, which is not ideal but whatever. Refs jam1garner#224.
A reasonable workaround: - name: Read crate metadata
id: metadata
run: echo "rust-version=$(sed -ne 's/rust-version *= *\"\(.*\)\"/\1/p' Cargo.toml)" >> $GITHUB_OUTPUT
- name: Install Rust
uses: dtolnay/rust-toolchain@master
with:
toolchain: ${{ steps.metadata.outputs.rust-version }} |
I agree that this is seems like a needed feature - the action supports more exotic things like @dtolnay are there any specific reason you are thinking of that I don't see? Thanks for all the hard work! :) |
It would be useful if
rust-toolchain
could use whatever version is provided inrust-version
field in Cargo.toml. For example, it could look like this:The text was updated successfully, but these errors were encountered: