Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

bump yaml-rust to 0.4 #84

Merged
merged 1 commit into from
Nov 22, 2017
Merged

bump yaml-rust to 0.4 #84

merged 1 commit into from
Nov 22, 2017

Conversation

ignatenkobrain
Copy link
Contributor

Signed-off-by: Igor Gnatenko i.gnatenko.brain@gmail.com


Some tests are still failing, so help is very welcomed (probably those are bugs in yaml-rust)..

---- test_basic_struct stdout ----
	thread 'test_basic_struct' panicked at 'assertion failed: `(left == right)`
  left: `"---\nx: -4\ny: \"hi\\tquoted\"\nz: true"`,
 right: `"---\nx: -4\n\"y\": \"hi\\tquoted\"\nz: true"`', tests/test_serde.rs:27:4
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- test_map stdout ----
	thread 'test_map' panicked at 'assertion failed: `(left == right)`
  left: `"---\nx: 1\ny: 2"`,
 right: `"---\nx: 1\n\"y\": 2"`', tests/test_serde.rs:27:4

---- test_nested_vec stdout ----
	thread 'test_nested_vec' panicked at 'assertion failed: `(left == right)`
  left: `"---\n-\n  - 1\n  - 2\n  - 3\n-\n  - 4\n  - 5\n  - 6"`,
 right: `"---\n- - 1\n  - 2\n  - 3\n- - 4\n  - 5\n  - 6"`', tests/test_serde.rs:27:4

Signed-off-by: Igor Gnatenko <i.gnatenko.brain@gmail.com>
@killercup
Copy link
Contributor

same as #83?

@ignatenkobrain
Copy link
Contributor Author

didn't notice that one... I think there are some bugs somewhere... because I think that "y": "quoted\tstring" is the right one.

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 62a5434 into dtolnay:master Nov 22, 2017
@ignatenkobrain ignatenkobrain deleted the yaml0.4 branch November 22, 2017 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants