Warn about the rust-src component footgun in the docs
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
force-pushed
the
feat/add-rust-src-caveat-warning
branch
2 times, most recently
from
10a1417 to
d42f1c8
Compare
Veetaha
force-pushed
the
feat/add-rust-src-caveat-warning
branch
from
d42f1c8 to
412e9b6
Compare
dtolnay
approved these changes
Oct 15, 2024
cyrgani
added a commit
to cyrgani/enum_macros
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've stumbled on a problem where my compile error messages locally differed from the output on CI. This caused trybuild tests not to pass on CI, but pass locally:
Helpful people on Rust Zulip/Discord suggested that the difference was that I didn't have
rust-srcinstalled on CI. And that appeared to be the cause.I propose to add this caveat to the documentation so that people don't stumble on this again.