CurlWebSocketResponseBody: handle meta.bytesleft #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmedeiros
reviewed
Jul 13, 2024
| // the CURLWS_CONT bit set, so we buffer internally | ||
| if (meta.bytesleft == 0L) { | ||
| onFrame(partialFragBuffer, meta.flags) | ||
| partialFragBuffer = byteArrayOf() |
There was a problem hiding this comment.
is there any failure scenarios where we also need to do this?
There was a problem hiding this comment.
What do you mean by failure scenarios here? The callback would only be called when we receive data so there's no failure case as such, are you referring to needing this pattern in other places?
There was a problem hiding this comment.
if the connection drops while receiving data for example, I'd assume we would need to start partialFragBuffer from scratch.
There was a problem hiding this comment.
Ah that makes sense, I'll review the flow in this library and get back to you
dtretyakov
force-pushed
the
curl/ws
branch
2 times, most recently
from
0a9f16f to
f996e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client/Server, related modules
Motivation
Describe what problem this PR solves and why it is important. Refer to a bug/ticket #.
Solution
Describe your solution.