Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO AP sensing (Follow up of request #219 and #218) #220
IO AP sensing (Follow up of request #219 and #218) #220
Changes from 10 commits
3a6b5b2
11db29d
85a1a8c
f162003
2a38d29
97b3e75
2099385
2fe653e
0ab33a6
a98b31a
35148f9
b4ed021
79de203
d18f585
7840036
9e746fc
77c36b2
0bb2fc4
7ab23c0
20c9aff
6213332
ea32725
7e21fd4
c5e01f0
f597541
114e422
7433406
ff61e9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the current implementation is limited to in-memory reading only. Which is OK but would be good to state in the doc string/documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.