Exits working directory if wrapped function throws an exception.

[jevandezande]

If a function wrapped with @utils.work_in or @utils.work_in_tmp_dir throws an exception that is later caught, the working directory will be in the wrong location.

Note: @utils.work_in may have an unintended side-effect (unaffected by this PR). If an empty directory is passed to @utils.work_in, and nothing is produced in that directory, the directory will be deleted.

[t-young31]

Hi @jevandezande – thanks a lot for the PR, looks great to me. This behaviour is - unhelpfully - only implemented in

autodE/tests/testutils.py

Line 11 in 5166fc1

def work_in_zipped_dir(zip_path, chdir=True):

which is definitely the right approach 👍🏼

---

Could I ask a couple of things: (1) change the base to v1.3.1 branch and (2) add yourself to the contributor list on the README, if you're happy to be there, thanks!

[codecov]

Codecov Report

Merging #175 (5c4dc0b) into v1.3.1 (5166fc1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5c4dc0b differs from pull request most recent head 266980a. Consider uploading reports for the commit 266980a to get more accurate results

@@           Coverage Diff           @@
##           v1.3.1     #175   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files         194      194           
  Lines       19785    19807   +22     
=======================================
+ Hits        19180    19202   +22     
  Misses        605      605           

Flag	Coverage Δ
unittests	96.94% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
autode/utils.py	95.38% <100.00%> (+0.03%)	⬆️
tests/test_utils.py	95.70% <100.00%> (+0.60%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.