Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception on invalid molecule spin state #220

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

t-young31
Copy link
Member

Resolves #218

@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

Merging #220 (5866ee8) into v1.3.4 (af3daee) will increase coverage by 0.04%.
The diff coverage is 98.68%.

@@            Coverage Diff             @@
##           v1.3.4     #220      +/-   ##
==========================================
+ Coverage   97.08%   97.13%   +0.04%     
==========================================
  Files         195      196       +1     
  Lines       20011    20131     +120     
==========================================
+ Hits        19428    19554     +126     
+ Misses        583      577       -6     
Flag Coverage Δ
unittests 97.13% <98.68%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_neb.py 99.43% <ø> (ø)
tests/test_wrappers/test_gaussian.py 97.02% <ø> (ø)
tests/test_wrappers/test_nwchem.py 100.00% <ø> (ø)
tests/test_wrappers/test_qchem.py 100.00% <ø> (ø)
tests/test_log.py 93.75% <66.66%> (-6.25%) ⬇️
tests/test_calculation.py 99.27% <88.88%> (+<0.01%) ⬆️
tests/test_utils.py 96.51% <91.66%> (+0.19%) ⬆️
autode/__init__.py 100.00% <100.00%> (ø)
autode/atoms.py 100.00% <100.00%> (ø)
autode/calculations/calculation.py 99.31% <100.00%> (+<0.01%) ⬆️
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

autode/neb/original.py Outdated Show resolved Hide resolved
@t-young31 t-young31 marked this pull request as ready for review December 27, 2022 13:01
@t-young31 t-young31 linked an issue Jan 6, 2023 that may be closed by this pull request
Copy link
Collaborator

@shoubhikraj shoubhikraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, approved 👍

@t-young31 t-young31 merged commit ed3a17c into duartegroup:v1.3.4 Jan 10, 2023
@t-young31 t-young31 deleted the throw_on_invalid_spin_calc branch January 10, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throw if executing a calculation with an invalid spin state
2 participants