Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup with null filename #224

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

t-young31
Copy link
Member

Resolves #223

Note: with the example in #223 there is now no exception thrown, but I don't think any files are actually deleted 😕

@t-young31 t-young31 linked an issue Jan 6, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #224 (cbb8070) into v1.3.4 (af3daee) will increase coverage by 0.05%.
The diff coverage is 98.38%.

@@            Coverage Diff             @@
##           v1.3.4     #224      +/-   ##
==========================================
+ Coverage   97.08%   97.14%   +0.05%     
==========================================
  Files         195      196       +1     
  Lines       20011    20096      +85     
==========================================
+ Hits        19428    19522      +94     
+ Misses        583      574       -9     
Flag Coverage Δ
unittests 97.14% <98.38%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_wrappers/test_nwchem.py 100.00% <ø> (ø)
tests/test_calculation.py 99.25% <66.66%> (-0.02%) ⬇️
tests/test_log.py 93.75% <66.66%> (-6.25%) ⬇️
tests/test_utils.py 96.51% <91.66%> (+0.19%) ⬆️
autode/__init__.py 100.00% <100.00%> (ø)
autode/atoms.py 100.00% <100.00%> (ø)
autode/calculations/executors.py 98.37% <100.00%> (ø)
autode/conformers/conformer.py 100.00% <100.00%> (ø)
autode/hessians.py 99.17% <100.00%> (ø)
autode/reactions/reaction.py 97.61% <100.00%> (+0.21%) ⬆️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@shoubhikraj shoubhikraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished review, approved 👍

@t-young31 t-young31 merged commit 8452152 into duartegroup:v1.3.4 Jan 8, 2023
@t-young31 t-young31 deleted the t-young31/fix_cleanup branch January 8, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception in cleaning up after calculation with xTB
2 participants