Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests that use xTB on Windows #250

Merged
merged 6 commits into from
Mar 4, 2023

Conversation

shoubhikraj
Copy link
Collaborator

@shoubhikraj shoubhikraj commented Feb 18, 2023

The decorator @requires_with_working_xtb_install would previously always return on Windows since the .exe extension is returned by shutil. This PR fixes that bug.

(I didn't update the changelog because this should be covered under making autodE run on windows, I just didn't notice the issue in the previous PR)


Checklist

  • The changes include an associated explanation of how/why
  • Test pass
  • Documentation has been updated
  • Changelog has been updated

@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #250 (c495575) into v1.4.0 (1f42142) will increase coverage by 0.48%.
The diff coverage is 100.00%.

❗ Current head c495575 differs from pull request most recent head f1c21e3. Consider uploading reports for the commit f1c21e3 to get more accurate results

@@            Coverage Diff             @@
##           v1.4.0     #250      +/-   ##
==========================================
+ Coverage   96.86%   97.34%   +0.48%     
==========================================
  Files         195      195              
  Lines       20403    20410       +7     
==========================================
+ Hits        19763    19868     +105     
+ Misses        640      542      -98     
Flag Coverage Δ
unittests 97.34% <100.00%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_utils.py 97.37% <100.00%> (+14.55%) ⬆️
tests/testutils.py 94.59% <100.00%> (+0.30%) ⬆️
tests/test_graphs.py 100.00% <0.00%> (+1.06%) ⬆️
tests/test_ts/test_ts_template.py 97.52% <0.00%> (+1.65%) ⬆️
autode/mol_graphs.py 98.34% <0.00%> (+4.29%) ⬆️
autode/utils.py 95.45% <0.00%> (+12.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shoubhikraj shoubhikraj changed the base branch from master to v1.4.0 February 18, 2023 22:51
@shoubhikraj
Copy link
Collaborator Author

@t-young31 Could you please sync the master branch and the v1.4.0 branch because I am getting merge conflicts (from the doc updates, changelog etc. of v1.3.5 that wasn't present when the 1.4.0 branch was created)

Merge v1.4.0 into fix-xtb-win-run
@shoubhikraj
Copy link
Collaborator Author

The codecov test is failing on the upload stage, not sure why.

@shoubhikraj
Copy link
Collaborator Author

@t-young31 This PR is ready for review btw. I don't really know how to increase the diff hit for codecov because I have to see if the xTB is in path to be able to test the wrapper.

tests/test_utils.py Outdated Show resolved Hide resolved
@shoubhikraj
Copy link
Collaborator Author

@t-young31 Could you please rerun the pytest-codecov in windows, there is some error in uploading stage.

Copy link
Member

@t-young31 t-young31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a tiny suggestion 👍🏼

tests/test_utils.py Outdated Show resolved Hide resolved
shoubhikraj and others added 2 commits March 3, 2023 09:38
Co-authored-by: Tom Young <39765193+t-young31@users.noreply.github.com>
@t-young31 t-young31 merged commit 5f355e7 into duartegroup:v1.4.0 Mar 4, 2023
@shoubhikraj shoubhikraj deleted the fix-xtb-win-run branch April 13, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants