-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests that use xTB on Windows #250
Conversation
Codecov Report
@@ Coverage Diff @@
## v1.4.0 #250 +/- ##
==========================================
+ Coverage 96.86% 97.34% +0.48%
==========================================
Files 195 195
Lines 20403 20410 +7
==========================================
+ Hits 19763 19868 +105
+ Misses 640 542 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@t-young31 Could you please sync the master branch and the v1.4.0 branch because I am getting merge conflicts (from the doc updates, changelog etc. of v1.3.5 that wasn't present when the 1.4.0 branch was created) |
Merge v1.4.0 into fix-xtb-win-run
The codecov test is failing on the upload stage, not sure why. |
@t-young31 This PR is ready for review btw. I don't really know how to increase the diff hit for codecov because I have to see if the xTB is in path to be able to test the wrapper. |
@t-young31 Could you please rerun the pytest-codecov in windows, there is some error in uploading stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a tiny suggestion 👍🏼
Co-authored-by: Tom Young <39765193+t-young31@users.noreply.github.com>
The decorator
@requires_with_working_xtb_install
would previously always return on Windows since the.exe
extension is returned by shutil. This PR fixes that bug.(I didn't update the changelog because this should be covered under making autodE run on windows, I just didn't notice the issue in the previous PR)
Checklist