More comprehensive primitive generation #314
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v1.4.2 #314 +/- ##
==========================================
+ Coverage 97.37% 97.41% +0.03%
==========================================
Files 208 208
Lines 23451 23728 +277
==========================================
+ Hits 22836 23115 +279
+ Misses 615 613 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
looks awesome – thanks @shoubhikraj 🚀
most/all comments are suggestions. does need a changelog update
autode/opt/coordinates/internals.py
Outdated
| # prevent duplicate primitives | ||
| if item not in self: | ||
| super().append(item) |
There was a problem hiding this comment.
maybe this method should be add to be consistent with a Python set rather than append? to make it more clear that the append might not actually append anything
There was a problem hiding this comment.
@t-young31 Ok, I made it into add, but then I think the append should be disallowed, so that someone doesn't accidentally use it?
Partial fix for #312, #261 and #313.
Checklist