-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DHS variable step size #342
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.4.3 #342 +/- ##
==========================================
- Coverage 97.40% 97.38% -0.02%
==========================================
Files 200 202 +2
Lines 23108 23210 +102
==========================================
+ Hits 22509 22604 +95
- Misses 599 606 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM – added a couple of small suggestions
@t-young31 Could you please check one last time before merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome
(1) Uses multiple step sizes depending on the distance thresholds
(2) Replaces only gradient based peak detection to cubic polynomial based peak detection (both energies and gradients)
Checklist