Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHS variable step size #342

Merged
merged 18 commits into from
Jun 2, 2024
Merged

Conversation

shoubhikraj
Copy link
Collaborator

@shoubhikraj shoubhikraj commented May 24, 2024

(1) Uses multiple step sizes depending on the distance thresholds
(2) Replaces only gradient based peak detection to cubic polynomial based peak detection (both energies and gradients)


Checklist

  • The changes include an associated explanation of how/why
  • Test pass
  • Documentation has been updated
  • Changelog has been updated

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 99.34211% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.38%. Comparing base (598b2dc) to head (5e09fa6).

Files Patch % Lines
autode/opt/optimisers/utils.py 98.59% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           v1.4.3     #342      +/-   ##
==========================================
- Coverage   97.40%   97.38%   -0.02%     
==========================================
  Files         200      202       +2     
  Lines       23108    23210     +102     
==========================================
+ Hits        22509    22604      +95     
- Misses        599      606       +7     
Flag Coverage Δ
unittests 97.38% <99.34%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shoubhikraj shoubhikraj changed the base branch from master to v1.4.3 May 25, 2024 10:18
@shoubhikraj shoubhikraj changed the title DHS auto step adjustment DHS variable step size May 27, 2024
@shoubhikraj shoubhikraj marked this pull request as ready for review May 28, 2024 09:54
Copy link
Member

@t-young31 t-young31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM – added a couple of small suggestions

autode/opt/optimisers/utils.py Outdated Show resolved Hide resolved
autode/opt/optimisers/utils.py Outdated Show resolved Hide resolved
@shoubhikraj
Copy link
Collaborator Author

@t-young31 Could you please check one last time before merge?

Copy link
Member

@t-young31 t-young31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@shoubhikraj shoubhikraj merged commit c3359f5 into duartegroup:v1.4.3 Jun 2, 2024
13 of 14 checks passed
@shoubhikraj shoubhikraj deleted the dhs-step-adjust branch June 2, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants