-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add combination of bonds primitive and trust radius optimiser #345
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.4.4 #345 +/- ##
==========================================
+ Coverage 97.39% 97.43% +0.04%
==========================================
Files 202 204 +2
Lines 23278 23626 +348
==========================================
+ Hits 22672 23021 +349
+ Misses 606 605 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great – left some small suggestions 🚀
@t-young31 Hi, do you know why the tests are failing with a RecursionError on a numpy allclose call? I have no idea how this error is happening. |
looks like a major numpy update (https://github.com/duartegroup/autodE/actions/runs/9922667636/job/27421474592?pr=345#step:5:148) – will have a look for a solution. edit: Looks like we're hitting: Line 622 in 2f3af32
♻️ |
@t-young31 Could you have one last check before merge please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
(1) Adds a linear combination of bonds as a primitive
(2) Trust radius quasi-Newton optimiser
Checklist