-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements for generation of dataset of reaction profiles. #359
Minor improvements for generation of dataset of reaction profiles. #359
Conversation
Thanks for the PR @javialra97
This would be a breaking change, and pandas supports skipping rows natively import pandas as pd
pd.read_csv("<filename>", skiprows=1) so I'm not sure about that.
Interesting. I wouldn't be that adverse to this functionality, but can't think of a scenario where this would be useful. What did you have in mind?
On this I don't agree I'm afraid. I've not come across a situation where tight optimisations are worthwhile. Maybe if you're wanting super accurate frequencies and you've got a load of compute to burn then maybe, in my view.
Thanks! 😄 |
Hi @t-young31
I think the simplest case is when you have the resources to compute the full profile at a TZ/QZ basis set, in those cases a final single point is unnecessary. I have used it for benchmarking purposes, I want the geometries (with all the autodE checks) along the full profile to compute single points with N different functionals.
Well, I would prefer it to use the
Thanks to you for autodE! |
Sorry for the slow reply – work took over last week
Cool – sounds good 👍🏼
Hopefully the second try was successful! The following I think should work import autode as ade
ade.Config.G09.keywords.opt.remove('Opt')
ade.Config.G09.keywords.opt.append('Opt=Tight')
# likewise for ade.Config.G09.keywords.opt_ts To get this merged would you mind
Thanks 😄 |
Hi, I made the pertinent changes. Hope everything is fine Thanks! |
Awesome – thanks @javialra97 😄 It looks like there's a conflict on your branch, but looks like an easy one to resolve |
Hi @t-young31, I hope that is solved now 🙂 |
Looks like some Guassian frequency calculation tests are failing due to allowing the if "Input orientation" in line or ("Standard orientation" in line and len(coords) == 0): but we should fix this properly so that frequency calculation is okay irrespective of the orientation |
Hi @t-young31, In the As you said, the problem is in the hessian, the output of |
Sorry you hit this 😞. Have created #362 to track outside of this PR
I'm not sure the frequencies are fine.. https://github.com/duartegroup/autodE/actions/runs/11589659415/job/32265741467#step:6:205 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.4.5 #359 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 204 204
Lines 23758 23759 +1
=======================================
+ Hits 23148 23150 +2
+ Misses 610 609 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Yes, is true, I only checked the one for H2 but the acetylene frequencies are wrong 😔 Maybe instead of taking the geometries from the The error now is also because of taking a different geometry? |
We could, but then it'd still potentially be broken for Opt+Freq calculations that don't print the input orientation coordinates. I'll find a way to fix it properly, or at least try!
I don't think so. @shoubhikraj have you got any ideas? it's Windows+TRM so your world. Python 3.8 looks like it's just end of life, so shall we just drop support? |
It seems that Gaussian is a little messy with the outputs. But I was checking my outputs and the one that you have in
Great! Glad to help a little bit. |
@t-young31 Honestly I am not sure where the error is coming from... The hessian and gradient are loaded from stored matrices, and I have previously checked that it works. It does succeed with python 3.13, so maybe some issue with numpy or scipy versions. If it comes up later, then I might check in detail. I am fine with removing python 3.8 support, maybe in the next version - it was just made eol. |
output.csv
as a data frame (with pandas) can be problematic because of the first line, removing the line you will have a proper data frame with well-structured columns. Also, that information is printed in themethods.txt
file.Tight
.Checklist