-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gym_jiminy/rllib] Fix evaluation sampling. #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
duburcqa
commented
Jan 16, 2025
•
edited
Loading
edited
- [gym_jiminy/common] Trajectory time mode is not specific to each trajectory in the dataset.
- [gym_jiminy/common] Trajectory time offset is now a global attribute of the dataset.
- [gym_jiminy/common] 'QuantityManager' now has its own API instead of abusing mutable dict.
- [gym_jiminy/common] Stop relying on confusing dark-magic '__getattr__' in favor of explicit delegation.
- [gym_jiminy/common] Cleanup pipeline wrappers.
- [gym_jiminy/rllib] Fix evaluation sampling.
- [misc] Fix broken Python bindings docstring substitution.
5b83cf2
to
6daf555
Compare
b2c809c
to
1ed668a
Compare
…jectory while time offset is now global to the dataset.
…being a (strange) mutable dict.
…' in favor of explicit delegation.
Merged
duburcqa
added a commit
that referenced
this pull request
Jan 20, 2025
* [gym_jiminy/common] Fix hard-coded termination conditions not being recorded in 'info'. (#862) * [gym_jiminy/common] Fix 'log_path' not properly reset at setup. (#862) * [gym_jiminy/common] Fix 2D Euclidean space angle algebra for drift and shift termination conditions. (#865) * [gym_jiminy/common] Flatten info hierarchy for reward components. (#862) * [gym_jiminy/common] Do not store individual termination condition states in info. (#862) * [gym_jiminy/common] Use asymmetric sigmoid normalization for stability reward. (#862) * [gym_jiminy/common] Trajectory time mode is not specific to each trajectory in the dataset. (#863) * [gym_jiminy/common] Trajectory time offset is now a global attribute of the dataset. (#863) * [gym_jiminy/common] 'QuantityManager' now has its own API instead of abusing mutable dict. (#863) * [gym_jiminy/common] Stop relying on confusing dark-magic '\_\_getattr\_\_' in favor of explicit delegation. (#863) * [gym_jiminy/common] Add instantaneous mechanical power quantity. (#862) * [gym_jiminy/common] Add support of ellipsis to 'MaskedQuantity'. (#862) * [gym_jiminy/common] Add generic concatenation quantity. (#862) * [gym_jiminy/common] Add quantity computing reference position vector with true odometry pose. (#862) * [gym_jiminy/common] Add option to allow registering variables to the telemetry in training mode. (#862) * [gym_jiminy/common] Add ellipsis support in pipeline configuration files. (#862) * [gym_jiminy/toolbox|rllib] Task-settable capability is now provided by a wrapper. (#864) * [gym_jiminy/rllib] Fix evaluation sampling. (#863) * [misc] Fix doc generation. (#862) * [misc] Fix broken Python bindings docstring substitution. (#863)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.