Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add experimental "custom slices" constraint on array #3048

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jul 4, 2022

This new constraint not officially exposed to fast-check's users (in other words, name might change in patch, minor... without any precise warning), should unlock the feature "Helper to deal with dangerous strings" #484 by making it feasible.

So far, it only provides an extra constraint on the API of array but it will soon be leveraged for arbitraries on strings.

Category:

  • ✨ Introduce new features
  • 📝 Add or update documentation
  • ✅ Add or update tests
  • 🐛 Fix a bug
  • 🏷️ Add or update types
  • ⚡️ Improve performance
  • Other(s): ...

Potential impacts:

  • Generated values
  • Shrink values
  • Performance
  • Typings
  • Other(s): ...

dubzzz added 2 commits July 4, 2022 22:09
This new constraint not officially exposed to fast-check's users (in other words, name might change in patch, minor... without any precise warning), should unlock the feature "Helper to deal with dangerous strings" #484 by making it feasible.

So far, it only provides an extra constraint on the API of `array` but it will soon be leveraged for arbitraries on strings.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46f4ffd:

Sandbox Source
Vanilla Configuration
@fast-check/examples Configuration

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #3048 (46f4ffd) into main (8607cb7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3048   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files         209      209           
  Lines        5293     5296    +3     
  Branches     1024     1025    +1     
=======================================
+ Hits         5075     5078    +3     
  Misses        218      218           
Flag Coverage Δ
unit-tests 95.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/fast-check/src/arbitrary/array.ts 100.00% <ø> (ø)
packages/fast-check/src/arbitrary/uniqueArray.ts 100.00% <ø> (ø)
...t-check/src/arbitrary/_internals/ArrayArbitrary.ts 100.00% <100.00%> (ø)
...eck/src/arbitrary/_internals/FrequencyArbitrary.ts 98.11% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8607cb7...46f4ffd. Read the comment docs.

@dubzzz dubzzz merged commit b99277b into main Jul 4, 2022
@dubzzz dubzzz deleted the new-experimental-custom-slices-array branch July 4, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant