-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅(worker) Run tests against workers in ESM mode #4648
base: main
Are you sure you want to change the base?
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 76a2b5f:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
It seems that when trying to open a worker in MJS mode, it crashes immediately because it cannot find the package for fast-check. new w.Worker(new URL('file:///workspaces/fast-check/packages/worker/test/e2e/__properties__/passing.mjs'))
// Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'fast-check' imported from /workspaces/fast-check/packages/worker/test/e2e/__properties__/passing.mjs
// at packageResolve (node:internal/modules/esm/resolve:844:9)
// at moduleResolve (node:internal/modules/esm/resolve:901:20)
// at defaultResolve (node:internal/modules/esm/resolve:1121:11)
// at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
// at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
// at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
// at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
// at link (node:internal/modules/esm/module_job:84:36) I imagine something around how packages get installed with Yarn. |
It works fine in a |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Plop |
Category:
Potential impacts: