Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add option to generate unicode values in json #5011

Merged
merged 6 commits into from
May 22, 2024
Merged

✨ Add option to generate unicode values in json #5011

merged 6 commits into from
May 22, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented May 22, 2024

Description

Same idea as for #5010 but extended to json and jsonValue.

With this new flag, we also deprecate unicode versions as they don't need to live on their own anymore. As such they can just be replaced by the default version. The flag is by default to true but will be moved to false in v4.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✨ Introduce new features
  • Impacts: Deprecate arbitraries

Copy link

codesandbox-ci bot commented May 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d8b241a:

Sandbox Source
@fast-check/examples Configuration

@dubzzz dubzzz enabled auto-merge (squash) May 22, 2024 18:40
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.88%. Comparing base (927e173) to head (90e9a7e).
Report is 8 commits behind head on main.

Current head 90e9a7e differs from pull request most recent head d8b241a

Please upload reports for the commit d8b241a to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5011   +/-   ##
=======================================
  Coverage   96.87%   96.88%           
=======================================
  Files         213      213           
  Lines       16296    16346   +50     
  Branches     2667     2670    +3     
=======================================
+ Hits        15787    15837   +50     
  Misses        509      509           
Flag Coverage Δ
unit-tests 96.88% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x-Linux 96.88% <100.00%> (+<0.01%) ⬆️
unit-tests-20.x-Linux 96.88% <100.00%> (+<0.01%) ⬆️
unit-tests-22.x-Linux 96.88% <100.00%> (+<0.01%) ⬆️
unit-tests-latest-Linux 96.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👋 A preview of the new documentation is available at: http://664e45341d3f201e642c7755--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit 49abe92 into main May 22, 2024
57 checks passed
@dubzzz dubzzz deleted the json-new-uni branch May 22, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant