Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Check types with multiple TypeScript #5074

Merged
merged 12 commits into from
Jun 25, 2024
Merged

🔧 Check types with multiple TypeScript #5074

merged 12 commits into from
Jun 25, 2024

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jun 21, 2024

Description

The explicit install of specific TypeScript versions got dropped a long time ago during a change of the configuration. As a consequence the build process was only checking types against the last stable release of TypeScript.

ChecklistDon't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: CI
  • Impacts: CI build chain of fast-check repo

The explicit install of specific TypeScript version got dropped a long time ago during a change of the configuration.
Copy link

codesandbox-ci bot commented Jun 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb4e25b:

Sandbox Source
@fast-check/examples Configuration

Copy link
Contributor

👋 A preview of the new documentation is available at: http://66752921ab5bad34957b03cd--dubzzz-fast-check.netlify.app

Copy link
Contributor

👋 A preview of the new documentation is available at: http://66752ab7ab5bad35c87b052d--dubzzz-fast-check.netlify.app

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.89%. Comparing base (2b70cb5) to head (bb4e25b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5074   +/-   ##
=======================================
  Coverage   96.89%   96.89%           
=======================================
  Files         215      215           
  Lines       16384    16384           
  Branches     2671     2671           
=======================================
  Hits        15875    15875           
  Misses        509      509           
Flag Coverage Δ
unit-tests 96.89% <ø> (ø)
unit-tests-18.x-Linux 96.89% <ø> (ø)
unit-tests-20.x-Linux 96.89% <ø> (ø)
unit-tests-22.x-Linux 96.89% <ø> (ø)
unit-tests-latest-Linux 96.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👋 A preview of the new documentation is available at: http://66792505ff107b4b613e5299--dubzzz-fast-check.netlify.app

Copy link
Contributor

👋 A preview of the new documentation is available at: http://667a737133e46cbc26f1fd4d--dubzzz-fast-check.netlify.app

Copy link
Contributor

👋 A preview of the new documentation is available at: http://667b1e3f3ff72066926ce873--dubzzz-fast-check.netlify.app

Copy link
Contributor

👋 A preview of the new documentation is available at: http://667b2160a7e1c4608fb3f02d--dubzzz-fast-check.netlify.app

@dubzzz dubzzz merged commit 89aa88c into main Jun 25, 2024
75 checks passed
@dubzzz dubzzz deleted the multi-ts branch June 25, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant